debian: move to use dh_install.

The way we previously used dh_movefiles is not safe to use with
`dpkg-buildpackage -A`, end with a real source-only upload ended up in files
belonging to pbuilder-uml in the pbuilder binary.

This is suboptimal, given that we duplicate the list of what we install

Closes: #800416

4 files changed, 22 insertions, 11 deletions

diff --git a/debian/pbuilder-uml.files b/debian/pbuilder-uml.install
index 8aadb89..8aadb89 100644
--- a/debian/pbuilder-uml.files
+++ b/debian/pbuilder-uml.install
diff --git a/debian/pbuilder.dirs b/debian/pbuilder.dirs
index 34e7e70..d014913 100644
--- a/debian/pbuilder.dirs
+++ b/debian/pbuilder.dirs
@@ -1,7 +1,3 @@
-usr/bin
-usr/lib/pbuilder
-usr/sbin
-var/cache/pbuilder
 var/cache/pbuilder/aptcache
 var/cache/pbuilder/build
 var/cache/pbuilder/ccache
diff --git a/debian/pbuilder.install b/debian/pbuilder.install
new file mode 100644
index 0000000..759770e
--- /dev/null
+++ b/debian/pbuilder.install
@@ -0,0 +1,22 @@
+usr/sbin/pbuilder
+usr/share/pbuilder/pbuilderrc
+usr/lib/pbuilder/pbuilder-apt-config
+usr/lib/pbuilder/pbuilder-buildpackage*
+usr/lib/pbuilder/pbuilder-checkparams
+usr/lib/pbuilder/pbuilder-createbuildenv
+usr/lib/pbuilder/pbuilder-loadconfig
+usr/lib/pbuilder/pbuilder-modules
+usr/lib/pbuilder/pbuilder-runhooks
+usr/lib/pbuilder/pbuilder-satisfydepends*
+usr/lib/pbuilder/pbuilder-unshare-wrapper
+usr/lib/pbuilder/pbuilder-updatebuildenv
+
+usr/bin/pdebuild
+usr/lib/pbuilder/pdebuild-checkparams
+usr/lib/pbuilder/pdebuild-internal
+
+/usr/bin/debuild-pbuilder
+/etc/pbuilder/buildd-config.sh
+/usr/share/bash-completion/completions/pbuilder
+
+usr/share/doc
diff --git a/debian/rules b/debian/rules
index 1647df8..7ca6938 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,13 +4,6 @@ export DH_VERBOSE=1
 %:
 	dh $@
 
-override_dh_auto_install:
-	dh_auto_install --destdir=$(CURDIR)/debian/pbuilder
-
-override_dh_install:
-	dh_movefiles --sourcedir=debian/pbuilder
-	dh_install
-
 override_dh_compress:
 	dh_compress -X.pdf