aboutsummaryrefslogtreecommitdiff
path: root/doc/todo/turn_edittemplate_verbosity_off_by_default.mdwn
blob: 14bb437824f802e3c2832b74f7b72d810d256daf (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
`edittemplate` replaces its directive with a note like "edittemplate person
registered for people/*". It would be nice if this were dependent on
a `verbose` parameter and default to off. I don't see the value in it, and by
disabling the output, I can keep template registration as close as possible to
the action as needed.

I think this (untested) patch might just do the trick:

    --- a/IkiWiki/Plugin/edittemplate.pm
    +++ b/IkiWiki/Plugin/edittemplate.pm
    @@ -46,8 +46,13 @@ sub preprocess (@) {

      $pagestate{$params{page}}{edittemplate}{$params{match}}=$params{template};

    -       return sprintf(gettext("edittemplate %s registered for %s"),
    -               $params{template}, $params{match});
    +       if (yesno($params{verbose})) {
    +               return sprintf(gettext("edittemplate %s registered for %s"),
    +                       $params{template}, $params{match});
    +       }
    +       else {
    +               return '';
    +       }
    }

    sub formbuilder (@) {

--[[madduck]]

[[!tags wishlist patch]]

[[done]], though the patch I eventually applied uses "silent" as the
parameter name. Sorry for forgetting about this patch until someone else
implemented it too. --[[Joey]]