aboutsummaryrefslogtreecommitdiff
path: root/doc/plugins/filecheck/discussion.mdwn
blob: f91950b7df39a894c63f54991c885f019cde73c1 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
First, thanks again for making this plugin.

I don't know if this is a problem for [[plugins/attachment]], but there seems to
be no way to detect text/plain using File::MimeInfo::Magic::magic().
There is a heuristic ::default that decides between text/plain and application/octet-stream.  

Would you be receptive to a patch that e.g. called File::MimeInfo::Magic::default()
if ::magic() returns undef?  --[[DavidBremner]]

> Yes, that looks to be ok. --[[Joey]]

>> OK, here is such a patch. One modification of previous behaviour is that 
>> that if default returns undef, this is returned. As far as I understand
>> the code/doc for File::MimeInfo, under is used only as an error return
>> for ::default

>>> Applied