aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs/po:_plugin_should_not_override_the_title_on_the_homepage.mdwn
blob: 35e932188020c485da3f87e6df34cdcef1a18780 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
The po plugin systematically overrides the title of the homepage with the wikiname. This prevents explicitly changing it with a meta directive. It should rather check whether it was overridden before setting it back.

Here is a simple patch for that:

    diff --git a/Plugin/po.pm b/Plugin/po.pm
    index 6395ebd..a048c6a 100644
    --- a/Plugin/po.pm
    +++ b/Plugin/po.pm
    @@ -333,7 +333,7 @@ sub pagetemplate (@) {
                && $masterpage eq "index") {
                    $template->param('parentlinks' => []);
            }
    -       if (ishomepage($page) && $template->query(name => "title")) {
    +       if (ishomepage($page) && $template->query(name => "title") && !$template->query(name => "title_overridden")) {
                    $template->param(title => $config{wikiname});
            }
     }

Thanks.

> I fixed this patch and applied in my po branch, thanks.
> (This is commit 406485917, please pull.) --[[intrigeri]]