blob: a9b223a465cabbc5cc9b3820f6ea4d43ec9345fd (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
|
A [[PageSpec]] that is entirely negated terminals, such as "!foo and !bar"
matches all other pages, including all internal pages. This can lead to
unexpected results, since it will match a bunch of recentchanges pages,
etc.
Recall that internal-use pages are not matched by a glob. So "\*" doesn't
match them. So if the pagespec is "\* and !foo and !bar", it won't match
them. This is the much more common style.
There's an odd inconsistency with entirely negated pagespecs. If "!foo"
matches page bar, shouldn't "" also match bar? But, the empty pagespec is
actually special-cased to not match anything.
Indeed, it seems what would be best would be for "!foo" to not match any
pages, unless it's combined with a terminal that positively matches pages
("* and !foo"). Although this would be a behavior change, with transition
issues.
Another approach would be to try to detect the case of an entirely negated
pagespec, and implicitly add "and !internal()" to it.
Either approach would require fully parsing the pagespec. And consider cases
like "!(foo and !bar)". Doesn't seem at all easy to solve. --[[Joey]]
> It occurs to me that at least one place in ikiwiki optimizes by assuming
> that pagespecs not mentioning the word "internal" never match internal
> pages. I wonder whether this bug could be solved by making that part of
> the definition of a pagespec, rather than a risky optimization
> like it is now? That seems strange, though - having this special case
> would make pagespecs significantly harder to understand. --[[smcv]]
|