blob: b6c7717807453a20e88a025bf940fae9fd59f025 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
|
Hello,
I have just updated an ikiwiki installation of mine from the `master` branch in 2014
to the current `master` (430f69034f7c9f64325ef48da3b3eaf0d685dcc5), and found out that the
the footnote support with MultiMarkdown is broken. After some investigation, I believe that
the breakage was introduced in 4db4e589e4c73f076b666a77b86743695454a3ce, with Discount support
for footnotes. The conditional for the footnote support in MultiMarkdown is inverted.
I've been running with this patch to fix it:
From 8c624b3cc67bf41b3987a27b15a8dee5fe1087f7 Mon Sep 17 00:00:00 2001
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Thu, 29 Aug 2019 16:51:45 +0200
Subject: [PATCH] Fix inverted conditional for multimarkdown footnote support
---
IkiWiki/Plugin/mdwn.pm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/IkiWiki/Plugin/mdwn.pm b/IkiWiki/Plugin/mdwn.pm
index eefa29a97..cff4204ef 100644
--- a/IkiWiki/Plugin/mdwn.pm
+++ b/IkiWiki/Plugin/mdwn.pm
@@ -77,9 +77,7 @@ sub htmlize (@) {
$markdown_sub=sub {
my %flags=( use_metadata => 0 );
- if ($config{mdwn_footnotes}) {
- $flags{disable_footnotes}=1;
- }
+ $flags{disable_footnotes}= not $config{mdwn_footnotes};
Text::MultiMarkdown::markdown(shift, \%flags);
}
--
2.21.0.595.g6364b05174
[[!tag patch]]
[[done]]
> Applied (along with some accompanying tests) in e642784. Thanks for
> finding and fixing the bug.
> --[[schmonz]]
|