1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
The following patch adds a footer div on all pages to ease CSS themeing.
Indeed, the misc.tmpl, recentchanges.tmpl and editpage.tmpl templates lack such a div.
> So, the problem with this is that the default css inserts a horizontal
> line at the top of the footer div, and putting an empty footer on these
> other pages looks a bit weird. Any idea how to get around that?
> --[[Joey]]
>> Sorry I didn't see that. It definitely looks weird. We could add text
>> in all footers or change the CSS stylesheet, but it's not clean IMHO.
>> The idea was about to ease themeing by giving all the pages the same
>> structure. The current structure is the following one:
>> div header - div actions ... div content - div footer (sometimes)
>> So we could add some new divs in all templates. By default, they will
>> be empty and no CSS will be defined for them. This way ikiwiki
>> standard appearance is not changed but themeing will be eased.
>> The new page structure could be:
>> * div banner (to show up a logo for example)
>> * div content-wrap containing div header, div actions, ... div content
>> and div footer
>> * div realfooter (to put credits, "Powered by ikiwiki", "Valid XHTML"...)
>> From my tests, it works: Just adding the divs, without touching the stylesheet,
>> doesn't change ikiwiki appearance. And themeing is eased :-)
>> I can update the patch, if you want to follow and test this idea. --Fred
>>> Sure, go ahead --[[Joey]]
>>>>Here is an updated patch against current svn. --Fred
Index: templates/recentchanges.tmpl
===================================================================
--- templates/recentchanges.tmpl (révision 3575)
+++ templates/recentchanges.tmpl (copie de travail)
@@ -12,7 +12,11 @@
</TMPL_IF>
</head>
<body>
+<div id="banner">
+</div>
+<div id="content-wrap">
+
<div class="header">
<span>
<TMPL_VAR INDEXLINK>/ <TMPL_VAR TITLE>
@@ -65,5 +69,10 @@
<!-- from <TMPL_VAR NAME=WIKINAME> -->
+</div>
+
+<div id="realfooter">
+</div>
+
</body>
</html>
Index: templates/page.tmpl
===================================================================
--- templates/page.tmpl (révision 3575)
+++ templates/page.tmpl (copie de travail)
@@ -13,7 +13,11 @@
<TMPL_IF NAME="META"><TMPL_VAR META></TMPL_IF>
</head>
<body>
+<div id="banner">
+</div>
+<div id="content-wrap">
+
<div class="header">
<span>
<TMPL_LOOP NAME="PARENTLINKS">
@@ -95,5 +99,10 @@
<TMPL_IF EXTRAFOOTER><TMPL_VAR EXTRAFOOTER></TMPL_IF>
</div>
+</div>
+
+<div id="realfooter">
+</div>
+
</body>
</html>
Index: templates/editpage.tmpl
===================================================================
--- templates/editpage.tmpl (révision 3575)
+++ templates/editpage.tmpl (copie de travail)
@@ -12,6 +12,11 @@
</TMPL_IF>
</head>
<body>
+<div id="banner">
+</div>
+
+<div id="content-wrap">
+
<TMPL_IF NAME="PAGE_CONFLICT">
<p>
<b>Your changes conflict with other changes made to the page.</b>
@@ -86,5 +91,11 @@
<TMPL_VAR PAGE_PREVIEW>
</div>
</TMPL_IF>
+
+</div>
+
+<div id="realfooter">
+</div>
+
</body>
</html>
Index: templates/misc.tmpl
===================================================================
--- templates/misc.tmpl (révision 3575)
+++ templates/misc.tmpl (copie de travail)
@@ -12,7 +12,11 @@
</TMPL_IF>
</head>
<body>
+<div id="banner">
+</div>
+<div id="content-wrap">
+
<div class="header">
<span>
<TMPL_VAR INDEXLINK>/ <TMPL_VAR TITLE>
@@ -23,5 +27,10 @@
<TMPL_VAR PAGEBODY>
</div>
+</div>
+
+<div id="realfooter">
+</div>
+
</body>
</html>
> I took a more intrusive approach to avoid ugly names like "realfooter".
> [[done]] --[[Joey]]
|