| Commit message (Expand) | Author | Age |
|---|
| * | Bump test count for previous. | Amitai Schlair | 2013-02-02 |
| * | Fix diffurl links (cvsweb expects unescaped '/'). | Amitai Schlair | 2013-02-02 |
| * | Fix longstanding bug (chdir to nonexistent dirs).•••In test, set up the post-commit hook for more realism (and bugs!).
To make wrappers work in test, set PERL5LIB, and allow the wrappee's
path to be overridden. Meta-test that post-commit is really hooked
up by verifying that content is getting generated in destdir.
About the longstanding bug, which as far as I know was harmless:
CVS can't operate outside a srcdir, so we're always setting $CWD.
"local $CWD" restores the previous value when we go out of scope.
Usually that's correct. But if we're removing the last file from a
directory, the post-commit hook will exec in a working directory
that's about to not exist (CVS will prune it).
The fix: chdir() manually in cvs_runcvs(), so we can selectively
not chdir() back.
| Amitai Schlair | 2013-01-27 |
| * | Notes. | Amitai Schlair | 2012-02-05 |
| * | More testings and fixings:•••* Test that adding a text file under a name formerly tracked as
binary (and vice versa) gets the right keyword-substitution
behavior.
* Explicitly set -kkv for text files to make the tests pass.
* CVS warns in these cases about "changing keyword expansion mode",
but this is correct behavior, so filter it from stderr. Filter
stdout the same way in case we ever want to keep any of it.
* In rcs_add(), replace comments with obviousness.
| Amitai Schlair | 2012-02-05 |
| * | Remember to run all the tests before committing! | Amitai Schlair | 2012-02-05 |
| * | Test checkconfig(). | Amitai Schlair | 2012-02-05 |
| * | Test RCS Id keyword expansion on typical commit. | Amitai Schlair | 2012-02-05 |
| * | Notes from an evening's debugging. | Amitai Schlair | 2012-02-05 |
| * | Write rcs_diff() tests according to the API spec, then make them pass. | Amitai Schlair | 2012-02-05 |
| * | Update test plan, missed in previous. | Amitai Schlair | 2012-02-01 |
| * | Express rcs_recentchanges() tests via utility functions, in preparation•••for writing more thorough tests, in order to safely extract the
cvsps output-parsing routine for reuse by an upcoming rcs_revert().
| Amitai Schlair | 2012-02-01 |
| * | Fail a test if an rcs_receive() hook is ever defined for CVS. | Amitai Schlair | 2012-02-01 |
| * | Extract add_and_commit(), a common test action. | Amitai Schlair | 2012-02-01 |
| * | Uncomment the CVS keyword substitution mode tests, and make them pass:•••Extract cvs_keyword_subst_args() and ensure it runs in $config{srcdir}.
Using Perl's -T operator appears to work equally well, perhaps switch?
| Amitai Schlair | 2012-01-26 |
| * | Move tests that simulate web commits into test_rcs_add(), then add•••a bunch more tests (that wind up exercising rcs_commit(),
rcs_commit_staged(), and rcs_recentchanges()). Extract some support
routines for brevity. Most is_in_keyword_substitution_mode() tests
are commented out because there's a bug -- non-binary files are
being added with "cvs add -kb".
Move tests that inspect recentchanges after direct CVS operations
into test_rcs_recentchanges().
| Amitai Schlair | 2012-01-24 |
| * | Define required programs and modules at top for easy spotting. | Amitai Schlair | 2012-01-22 |
| * | No functional change: sort sub definitions.•••In the code:
* general plugin API calls (in plugins/write order),
* VCS plugin API calls (in plugins/write order), then
* internal support routines (in alphabetical order).
In the tests:
* general meta-behavior (in no particular order, yet),
* general plugin API calls (in plugins/write order),
* VCS plugin API calls (in plugins/write order), then
* internal support routines (in semi-logical order).
| Amitai Schlair | 2012-01-22 |
| * | Test::Class runs test subs in alphabetical order, so we do too. | Amitai Schlair | 2012-01-22 |
| * | Ape xUnit more closely to remove ordering constraints on test subs:•••* Add setup and teardown methods, called before and after every test sub.
* In setup, make a fresh repo; in teardown, throw it out.
* Extract runtests method and define default test methods at top.
* Move reflection routines near the xUnit-style subs they support.
Adapt existing test subs to run independently:
* In test_manual_add_and_commit(), assume a fresh repo.
While here, plan a bit better:
* Check for all modules used by cvs.pm.
* Check for program existence more generally.
* Check that we can rmdir after mkdir.
| Amitai Schlair | 2012-01-22 |
| * | Describe the needed test cases, and implement a couple Test::Class features.•••* Run all subs matching /^test_*/ (for which we can plan)...
* Unless TEST_METHOD is set, in which case run matching subs (sans plan).
* Define total number of tests very near 'use Test::More', where expected.
* Define test tempdir where it's declared, no longer any reason why not.
* Move most comments from TODO.cvs into t/cvs.t.
* Add a whole bunch more comments describing the needed test cases.
XXX existing tests are order-dependent, but currently happen to pass
| Amitai Schlair | 2012-01-22 |
| * | Fix regression: failing to make the temp dir should nix the test plan.•••While here, nitpick style and wrap long lines.
| Amitai Schlair | 2012-01-22 |
| * | Use config parameters directly and shorten long lines. | Amitai Schlair | 2012-01-22 |
| * | * Define expected number of tests near the top.•••* Call readfile() directly from writefile().
* Parameterize commit message for the web-commit case.
* Describe intent of test cases.
* Rename test subs to match what they actually do.
* To prove extra path slashes don't cause trouble, instead of running
the same tests a second time, just assert that checkconfig()
strips the slashes.
| Amitai Schlair | 2012-01-22 |
| * | Fix a typo in the web commit test. | Amitai Schlair | 2012-01-22 |
| * | Simplify startup: use Test::More unconditionally, then determine•••the test plan at runtime. Use IkiWiki unconditionally too (as that's
not what I'm testing here) to avoid the TAP error of printing a
test result before having printed the plan.
| Amitai Schlair | 2012-01-22 |
| * | Extract subs: startup/shutdown, and tests for web and manual commits.•••No functional change intended.
| Amitai Schlair | 2012-01-22 |
| * | clean up messages about unavailable vcs programs | Joey Hess | 2010-06-25 |
| * | rcs_commit and rcs_commit_staged api changes•••Using named parameters for these is overdue. Passing the session in a
parameter instead of passing username and IP separately will later allow
storing other session info, like username or part of the email.
Note that these functions are not part of the exported API,
and the prototype change will catch (most) skew, so I am not changing
API versions. Any third-party plugins that call them will need updated
though.
| Joey Hess | 2010-06-23 |
| * | abort test if cvs prereq perl modules are not available | Joey Hess | 2009-10-14 |
| * | skip if cvsps is not available | Joey Hess | 2009-09-10 |
| * | CVS operations generally need to be within CVS checkouts, so these chdir()•••calls are warranted. They shouldn't modify the caller's working directory,
though. Use File::chdir to keep the scope of the changes subroutine-local.
The tests now pass without resetting the working directory.
| Amitai Schlair | 2009-09-10 |
| * | Add automated tests, modeled after svn's. Note the chdir() calls;•••perhaps cvs.pm should be doing pushd/popd in case the caller expects
its working directory to be left alone.
| Amitai Schlair | 2009-09-09 |