| Commit message (Expand) | Author | Age |
|---|
| * | Merge branch 'autotag' | Joey Hess | 2010-04-22 |
| |\ |
|
| | * | turn on tag_autocreate by default if tagbase is set | Joey Hess | 2010-04-21 |
| | * | Merge branch 'master' into autotag•••Conflicts:
IkiWiki/Plugin/tag.pm
| Joey Hess | 2010-04-21 |
| | |\ |
|
| | * | | fixes | Joey Hess | 2010-04-21 |
| | * | | clarify | Joey Hess | 2010-04-21 |
| | * | | Merge branch 'master' into autotag•••Conflicts:
IkiWiki/Plugin/tag.pm
| Joey Hess | 2010-04-21 |
| | |\ \ |
|
| | * | | | add separate template variable for tag page and sanitize displayed tag name | Joey Hess | 2010-04-21 |
| | * | | | remember autofiles that were tried and failed to be added•••This way, if an autofile is registered for a file that already exists,
it is remembered that it was tried, and it doesn't get recreated when
removed.
| Joey Hess | 2010-04-21 |
| | * | | | commit autocreated tag pages | Joey Hess | 2010-04-21 |
| | * | | | remember autofiles always•••This fixes the problem that it did not remember if an autofile is deleted,
unless a plugin happened to register the autofile at the same time.
With the new code, we just never recreate an autofile more than once.
Only downside is that the list of autofiles is never pruned either.
And I don't really see a way to prune it.
| Joey Hess | 2010-04-21 |
| | * | | | bugfixes | Joey Hess | 2010-04-21 |
| | * | | | remove verify_src_file•••Splitting out this function bothered me. It is conceptially similar to
file_pruned, and yet also very specific to exactly the security needs of
find_src_files.
I liked that it got rid of duplicate code in the latter function. So
instead, put a helper sub in that, which I think allows refactoring
things more cleanly, and with less boilerplate.
As to the needs of gen_autofile, I'm not convinced this needs to handle
the same set of problems that verify_src_file did. So I sat down and
wrote a custom validator for autofiles, which turned out to seem to just
need three things: Make sure the candidate filename is not something
that would be pruned; untaint the candidate filename; and make sure that
srcdir doesn't already have something with its name. (Plus, of course,
all the other checks that were already in gen_autofile.)
(In passing, also fixed a bunch of bugs I had introduced in this branch.)
| Joey Hess | 2010-04-21 |
| | * | | | Merge branch 'master' into autotag | Joey Hess | 2010-04-20 |
| | |\ \ \ |
|
| | * | | | | move File::Find control back into its code blocks•••Ok, this is longer, but features less scary action at a distance.
| Joey Hess | 2010-04-17 |
| | * | | | | move decode_utf8 closer to reason for it•••Filenames need to be decoded, as File::Find does not provide them in
decoded form, but other callers of verify_src_file will be using utf8.
| Joey Hess | 2010-04-17 |
| | * | | | | fix autotag behavior for relative tags•••A tag like ./foo is searched for relative to the tagging page.
However, if multiple pages use such a tag, the only one sure
to be in common is in the root, so autocreate it there to
avoid scattering redunadant autocreated tags around the tree.
(This is probably not ideal.)
Also renamed the tagpage and taglink functions for clarity.
| Joey Hess | 2010-04-17 |
| | * | | | | call gentag for taglinks too | Joey Hess | 2010-04-17 |
| | * | | | | fix autofile call | Joey Hess | 2010-04-17 |
| | * | | | | tag_autocreate fixups•••Fix style of prompt.
Optional to rebuild when it is changed. (Needed to get new all missing tags)
| Joey Hess | 2010-04-17 |
| | * | | | | refactor autofiles•••Made add_autofile take a generator function, and just register the
autofile, for later possible creation. The testing is moved into Render,
which allows cleaning up some stuff.
| Joey Hess | 2010-04-17 |
| | * | | | | whitespace | Joey Hess | 2010-04-17 |
| | * | | | | Merge remote branch 'davrieb/autotag' into autotag•••Conflicts:
IkiWiki.pm
IkiWiki/Plugin/tag.pm
| Joey Hess | 2010-04-17 |
| | |\ \ \ \ |
|
| | | * | | | | Make sure deleted tag pages don't get recreated.•••The reason to do this is basically a user interaction design decision.
It is achieved by adding an entry, associated to the creating plugin, to
%pagestate. To find out if files were deleted a new global hash %del_hash is
%introduced.
| David Riebenbauer | 2010-04-03 |
| | | * | | | | Revert "Revert the effects of find_del_files() for (re)autoadded files."•••This reverts commit 31680111f0062f07727d14fcf291c98978ad5a2f.
| David Riebenbauer | 2010-04-03 |
| | | * | | | | Check for existence off srcfile in add_autofile•••add_autofile has to have checks, whether to create the file, anyway, so this
will make things more consistent.
Correcter check for the result of verify_src_file().
Cosmetic rename of a variable $addfile to $autofile.
| David Riebenbauer | 2010-04-03 |
| | | * | | | | fix bugs in `find_src_files()`.•••Use `_` to avoid superfluous stat.
Check for `defined $file`, instead of just `$file`.
Add spaces after commas.
Change return values of `verify_src_file()` to not return the tainted filename.
Rename `$f` to `$file_untainted in `verify_src_file()`.
$f changes to `$file` in `find_src_files()`.
This attempts to fix commit f3abeac919c4736429bd3362af6edf51ede8e7fe.
For discussion see
<http://ikiwiki.info/todo/auto-create_tag_pages_according_to_a_template/>
| David Riebenbauer | 2010-02-03 |
| | | * | | | | Export add_autofile() for use in Plugins. | David Riebenbauer | 2010-02-02 |
| | | * | | | | Revert the effects of find_del_files() for (re)autoadded files.•••This also means that if autoadded files are deleted they will just be
recreated.
| David Riebenbauer | 2010-02-02 |
| | | * | | | | Use add_autofile() in tag.pm•••to make the automatically created tagpages render.
| David Riebenbauer | 2010-02-02 |
| | | * | | | | Process files from @autofiles in refresh().•••To make automatically added files render they have to be added to the $files,
$pages, $new, and $changed variables.
After that scan() is called on them.
| David Riebenbauer | 2010-02-02 |
| | | * | | | | Automatically create tag pages,•••if "tag_autocreate=1" is set in the configuration. The pages will be created in
tagbase, if and only if they do not exist in the srcdir yet. Tag pages will be create from
"autotag.tmpl".
At this stage a second refresh is needed for the tag pages to be rendered.
Add autotag.tmpl template.
| David Riebenbauer | 2010-02-02 |
| | | * | | | | Code deduplication fin find_src_files()•••This also has the advantage that I can use the resulting new function
elsewhere.
| David Riebenbauer | 2010-02-02 |
| * | | | | | | add influence info for failed metadata matches•••This is needed so that when a negated pagespec like "!author(foo)"
stops matching, due to the page being changed, ikiwiki knows that
the match was influenced by the page content.
| Joey Hess | 2010-04-22 |
| | |_|_|_|/
|/| | | | |
|
| * | | | | | remove broken ./tag support•••The commit that added the (working) support for using /tag to override
tagbase also tried to make ./tag work. Problem is, tags are links,
and ./foo is not a valid link (though I think there's a wishlist about it).
So, using ./tag really resulted in tag creation links that led to a
"bad page name" error. And even if the tag were created in the right place,
the link didn't go to it.
| Joey Hess | 2010-04-21 |
| | |_|_|/
|/| | | |
|
| * | | | | pass pagespec parameters along from match_tagged | Joey Hess | 2010-04-21 |
| * | | | | fix false positive in link_types_changed•••loadindex does not bother populating oldtypedlinks if there is no link
type. However, the code in link_types_changed assumed that if oldtypedlinks
is not defined, and typedlinks is, they must differ.
| Joey Hess | 2010-04-21 |
| | |_|/
|/| | |
|
| * | | | Merge branch 'file_pruned_revamp' | Joey Hess | 2010-04-20 |
| |\ \ \ |
|
| | * | | | bugfix•••So this is the one place that does need to canonpath and compare,
as two argument file_pruned used to.
| Joey Hess | 2010-04-20 |
| | * | | | bugfix•••Avoid file_pruned triggering on absolute paths causing the whole
comments_pending directory being pruned.
Simplify code.
| Joey Hess | 2010-04-20 |
| | * | | | Merge branch 'master' into file_pruned_revamp | Joey Hess | 2010-04-20 |
| | |\ \ \ |
|
| | * | | | | typo | Joey Hess | 2010-04-20 |
| | * | | | | fix stat to use unmunged filename | Joey Hess | 2010-04-20 |
| | * | | | | oops, fix for no_chdir mode•••$_ will be absolute then
| Joey Hess | 2010-04-20 |
| | * | | | | switch to 1 parameter version of file_pruned•••Another bit of code that didn't realize that File::Find sets $_ to the
relative filename.
| Joey Hess | 2010-04-20 |
| | * | | | | remove explicit absolute test•••file_pruned now tests for that
| Joey Hess | 2010-04-20 |
| | * | | | | use one parameter form of file_pruned here too•••In File::Find, $_ is relative to the current directory, so that is ok.
Also, the directory name doesn't need to be stripped from $_.
| Joey Hess | 2010-04-20 |
| | * | | | | clarify why absolute is tested & stripped here•••file_prune also fails on absolute filenames now
| Joey Hess | 2010-04-20 |
| | * | | | | Merge branch 'master' into file_pruned_revamp | Joey Hess | 2010-04-20 |
| | |\ \ \ \ |
|
| | * | | | | | unfinished file_prune revamp•••Many calls to file_prune were incorrectly calling it with 2 parameters.
In cases where the filename being checked is relative to the srcdir,
that is not needed.
Made absolute filenames be pruned. (This won't work for the 2 parameter call
style.)
| Joey Hess | 2010-04-17 |
| * | | | | | | darcs: ensure whole darcs query manifest output is consumed•••By a stroke of luck, after a long & full day, I happened to
remember that in the morning, I had seen someone on irc mention
that darcs query manifest doesn't like it if its full output
is not consumed.
So contrary to the usual case where bug reports sent via irc are like
messages written in sand before the new tide, this one was seen and
fixed.
(But use http://ikiwiki.info/bugs/ next time!)
| Joey Hess | 2010-04-20 |
| | |_|/ / /
|/| | | | |
|