| Commit message (Expand) | Author | Age |
|---|
| * | protect $@ whenever a block using $@ is non-trivial•••As noted in the Try::Tiny man page, eval/$@ can be quite awkward in
corner cases, because $@ has the same properties and problems as C's
errno. While writing a regression test for definetemplate
in which it couldn't find an appropriate template, I received
<span class="error">Error: failed to process template
<span class="createlink">deftmpl</span> </span>
instead of the intended
<span class="error">Error: failed to process template
<span class="createlink">deftmpl</span> template deftmpl not
found</span>
which turned out to be because the "catch"-analogous block called
gettext before it used $@, and gettext can call define_gettext,
which uses eval.
This commit alters all current "catch"-like blocks that use $@, except
those that just do trivial things with $@ (string interpolation, string
concatenation) and call a function (die, error, print, etc.)
| Simon McVittie | 2014-02-21 |
| * | inline: Allow overriding the title of the feed. Closes: #735123 Thanks, Chris... | Joey Hess | 2014-01-13 |
| * | Instead of hacking back to $link, just provide it. | Amitai Schlair | 2013-06-27 |
| * | Catch up rsspage to atompage. Validates. | Amitai Schlair | 2013-02-22 |
| * | Render fancy podcast enclosures.•••Simple podcast feeds didn't have content tags and I made sure to
keep it that way. This may be unnecessarily conservative. Changing
the behavior to include empty content tags might be fine, but I
don't want to think about it right now, I just want my tests to
keep passing!
The new fancy-podcast tests are copy-pasted-edited from the
simple-podcast tests. These tests shall be refactored.
| Amitai Schlair | 2013-02-20 |
| * | Extract genenclosure(). No functional change intended. | Amitai Schlair | 2013-02-20 |
| * | trail, inline: treat pagenames as a list of literal names, not links | Simon McVittie | 2012-04-06 |
| * | Reinstate trail support in inline•••This was removed in aaa72a3a80f89.
| Simon McVittie | 2012-04-05 |
| * | Added a "changes" hook. Renamed the "change" hook to "rendered", but•••the old hook name is called for now for back-compat.
| Joey Hess | 2012-03-28 |
| * | inline: When the pagenames list includes pages that do not exist, skip them.•••bestlink returns '' if no existing page matches a link. This propigated
through inline and other plugins, causing uninitialized value warnings, and
in some cases (when filecheck was enabled) making the whole directive fail.
Skipping the empty results fixes that, but this is papering over another
problem: If the missing page is later added, there is not dependency
information to know that the inline needs to be updated. Perhaps smcv will
fix that later.
| Joey Hess | 2012-03-21 |
| * | changelog | Joey Hess | 2012-03-18 |
| |\ |
|
| | * | Replace [[!trailinline]] directive with [[!inline trail=yes]] | Simon McVittie | 2012-03-18 |
| * | | Drop the version attribute on the generator tag in Atom feeds.•••Removing the version means that rebuilds are reproducible over time.
Both the generator tag and its version attribute are optional:
http://tools.ietf.org/html/rfc4287#section-4.2.4
| Paul Wise | 2012-03-03 |
| |/ |
|
| * | inline: When indexing internal pages for searching, use the url of the inlini... | Joey Hess | 2011-09-01 |
| * | inline: Handle obfuscated urls, such as the mailto urls generated by markdown...•••That took me 5 minutes. If anyone thinks obfuscated email urls stops, or
even slows down spammers, think again.
| Joey Hess | 2011-06-29 |
| * | inline: allow assigning an id to postform/feedlink•••This allows per-form/feedlink group customization without having to
resort to counting.
(cherry picked from commit b134feb0dc2d9a8ff7ae447537fa8bc02811aabd)
| Giuseppe Bilotta | 2011-02-22 |
| * | inline: base feed urls on included page name•••Second (forgotten) half of bb8f76a4a04686def8cc6f21bcca80cb2cc3b2c9.
This ensures that the link URL and page title in the feed are the
correct ones.
| Giuseppe Bilotta | 2011-02-22 |
| * | inline: Fix regression in feed titles. Closes: #610878 (Thanks, Paul Wise) | Joey Hess | 2011-01-24 |
| * | reword feed descs | Joey Hess | 2011-01-06 |
| * | inline: pass the Atom/RSS titles to the templates•••The default templates are also updated to make use of this information.
The rel="alternate" attribute is also inserted, for completeness.
(cherry picked from commit 618ade535e6a7967a510d9e210edaef3d37cc9bc)
| Giuseppe Bilotta | 2011-01-06 |
| * | inline: Force an absolute page location when the inline postform is used.•••There seems no need to allow selecting a location when creating a page this
way; the user should always want it to appear in the inline whose form they
submitted.
| Joey Hess | 2010-12-25 |
| * | fix comment | Joey Hess | 2010-12-25 |
| * | inline: base feed names on the included page name•••Use the included page name rather than the including page name. This
allows us to allow feeds in nested inlines without duplicating feeds
with the same content under different (and stupid) names.
| Giuseppe Bilotta | 2010-12-05 |
| * | Use local paths for the CGI URL | Simon McVittie | 2010-11-23 |
| * | inline: Improve RSS url munging to use a proper html parser•••and support all elements that HTML::Tagset knows about.
(Which doesn't include html5 just yet, but then the old version didn't either.)
Bonus: 4 times faster than old regexp method.
| Joey Hess | 2010-11-16 |
| * | indentation | Joey Hess | 2010-11-16 |
| * | template_depends: throw nice error message when template cannot be found•••plovs reported a crash when templates were not installed properly,
with a non-useful error about the template object not being defined.
I've audited all uses of template_depends(), and template(), and it makes
sense for them to throw an error if the template cannot be found. All code
with a user-supplied template catches errors already, to handle template
parse failures.
It did not make sense for template_file to throw errors, as some code uses
it to probe if a template file is available.
| Joey Hess | 2010-09-27 |
| * | revert accidentially committed change | Joey Hess | 2010-09-13 |
| * | Pass array of names of files that have been deleted to needsbuild hook as sec... | Joey Hess | 2010-09-10 |
| * | inline: Call indexhtml when inlining internal pages, so their text can be ind... | Joey Hess | 2010-05-06 |
| * | adapt comment.tmpl to html5•••Note that I put comment-header in a <header> despite it being
below the comment. Using a <footer> would be confusing given
the class name. Also, the content is semantically closer to
a header than a footer.
| Joey Hess | 2010-05-02 |
| * | Add parameter to displaytime to specify that it is a pubdate, and in html5 mo... | Joey Hess | 2010-05-02 |
| * | improved error message | Joey Hess | 2010-04-23 |
| * | use same error string as template.pm does | Joey Hess | 2010-04-23 |
| * | fix logic | Joey Hess | 2010-04-23 |
| * | look for templates in srcdir and underlays, first•••This entailed changing template_params; it no longer takes the template
filename as its first parameter.
Add template_depends to api and replace calls to template() with
template_depends() in appropriate places, where a dependency should be
added on the template.
Other plugins don't use template(), so will need further work.
Also, includes are disabled for security. Enabling includes only when using
templates from the templatedir would be nice, but would add a lot of
complexity to the implementation.
| Joey Hess | 2010-04-22 |
| * | disable feeds in raw mode | Joey Hess | 2010-04-15 |
| * | HTML-encode meta title, description, guid on output, but not in the pagestate•••This makes them consistent with the rest of the meta keys. A wiki rebuild
will be needed on upgrade to this version; until the wiki is rebuilt,
double-escaping will occur in the titles of pages that have not changed.
| Simon McVittie | 2010-04-06 |
| * | Group related plugins into sections in the setup file, and drop unused rcs pl... | Joey Hess | 2010-02-11 |
| * | inline: Avoid showing edit links if page editing is disabled. (Sjoerd) | Joey Hess | 2010-01-04 |
| * | Fix several places that did not properly handle capitalization of the discuss...•••Specifically, fixes discussion actions on discussion pages, and unbreaks the opendiscussion plugin.
| Joey Hess | 2010-01-02 |
| * | inline: Fix bug that limited displayed pages when feedshow was specified w/o ... | Joey Hess | 2010-01-01 |
| * | inline: Avoid using %links to test for page existence•••%links is populated even for just-deleted pages, so %pagesources
should be used for such tests instead.
| Joey Hess | 2009-11-30 |
| * | inline: Use caching of inlined pages to speed up builds of inlines that inclu...•••Speedup of about 25% for small inlines; could be much larger for inlines of
many, or complex pages.
Not bloating memory with excessive memoization data was the key to this.
The method chosen does not squeeze out every erg of speed possible when
inlines are nested, but that's rare. It uses less memory than other
optimisation hacks (I'm looking at you,
f937c1fb8074a512d8bb788fa275f5e90595cd47 !) already used in inline.pm.
| Joey Hess | 2009-11-17 |
| * | inline: Fix display of all pages when archive=yes or show=0 are used. | Joey Hess | 2009-11-13 |
| * | inline: Allow direct inclusion of non-page files in raw mode. | Joey Hess | 2009-11-13 |
| * | inline: Do not generated feeds for nested inlines.•••My experience is that when inlines are nested, the old behavior of
generating feeds for the nested inlines was never really desired. Since the
feeds were numbered sequentially, the numbers could easily change, and it did
not make sense to subscribe to or use those feeds. And generating those nested
feeds often meant a lot of unnecessary calculation, and data being written.
So, I dropped them.
Looking back, nested feeds originally were a free side effect of properly
handing multiple feeds on one page. Of course, that is still supported.
| Joey Hess | 2009-11-13 |
| * | inline: Fix raw mode. Closes: #552114 | Joey Hess | 2009-10-23 |
| * | slight optimisation | Joey Hess | 2009-10-15 |
| * | inline: Optimize generation of archives, etc•••Don't generate inlined page content if the template does not use it.
| Joey Hess | 2009-10-15 |