diff options
| author | Joey Hess <joey@gnu.kitenet.net> | 2009-06-08 18:27:40 -0400 |
|---|---|---|
| committer | Joey Hess <joey@gnu.kitenet.net> | 2009-06-08 18:33:54 -0400 |
| commit | 5418385336e7eeab79166e7ddccefa6bdea8c759 (patch) | |
| tree | 31fe6e4d56ea579c340e56bdce374d56dabc349a /t/basewiki_brokenlinks.t | |
| parent | 331cc6cca10cc01dd9730865c5078a24be3deedb (diff) | |
| download | ikiwiki-5418385336e7eeab79166e7ddccefa6bdea8c759.tar ikiwiki-5418385336e7eeab79166e7ddccefa6bdea8c759.tar.gz | |
Optimise use of gettext, and avoid ugly warnings if Locale::gettext is not available.
The test suite was emitting a lot of ugly gettext warnings;
setting LC_ALL didn't solve the problem for all locale setups
(since ikiwiki remaps it to LANG, and ikiwiki didn't know about
the C locale).
People also seem generally annoyed by the messages when
Locale::Gettext is not installed, and I suspect will be
generally happier if it just silently doesn't localize.
The optimisation came about when I noticed that the gettext
sub was doing rather a lot of work each call just to see
if localisation is needed. We can avoid that work by caching,
and the best thing to cache is a version of the gettext sub
that does exactly the right thing.
This was slightly complicated by the locale setting,
which might need to override the original locale (or lack
thereof) after gettext has been called. So it needs to invalidate
the cache in that case. It used to do it via a global variable,
which I am happy to have also gotten rid of.
Diffstat (limited to 't/basewiki_brokenlinks.t')
| -rwxr-xr-x | t/basewiki_brokenlinks.t | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/basewiki_brokenlinks.t b/t/basewiki_brokenlinks.t index 2871b1dd2..fd0037492 100755 --- a/t/basewiki_brokenlinks.t +++ b/t/basewiki_brokenlinks.t @@ -8,7 +8,7 @@ ok(! system("make -s ikiwiki.out")); ok(! system("make extra_install DESTDIR=`pwd`/t/tmp/install PREFIX=/usr >/dev/null")); foreach my $plugin ("", "listdirectives") { - ok(! system("LC_ALL=C perl -I. ./ikiwiki.out -rebuild -plugin brokenlinks ". + ok(! system("perl -I. ./ikiwiki.out -rebuild -plugin brokenlinks ". # always enabled because pages link to it conditionally, # which brokenlinks cannot handle properly "-plugin smiley ". |