diff options
| author | Simon McVittie <smcv@debian.org> | 2016-12-19 13:48:56 +0000 |
|---|---|---|
| committer | Simon McVittie <smcv@debian.org> | 2016-12-28 21:32:12 +0000 |
| commit | a8a7462382ff235086743f06a92a9ab9100083b4 (patch) | |
| tree | 0d69d59b5c84950aa17f8ca08df4bc5ba4f1118c /pm_filter | |
| parent | 469c842fd56ce811d431058714d9c2700a5314f8 (diff) | |
| download | ikiwiki-a8a7462382ff235086743f06a92a9ab9100083b4.tar ikiwiki-a8a7462382ff235086743f06a92a9ab9100083b4.tar.gz | |
Try revert operations (on a branch) before approving them
Otherwise, we have a time-of-check/time-of-use vulnerability:
rcs_preprevert previously looked at what changed in the commit we are
reverting, not at what would result from reverting it now. In
particular, if some files were renamed since the commit we are
reverting, a revert of changes that were within the designated
subdirectory and allowed by check_canchange() might now affect
files that are outside the designated subdirectory or disallowed
by check_canchange().
It is not sufficient to disable rename detection, since git older
than 2.8.0rc0 (in particular the version in Debian stable) silently
accepts and ignores the relevant options.
OVE-20161226-0002
Diffstat (limited to 'pm_filter')
0 files changed, 0 insertions, 0 deletions