aboutsummaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorsmcv <smcv@web>2014-07-04 07:12:58 -0400
committeradmin <admin@branchable.com>2014-07-04 07:12:58 -0400
commite68756dc789b45b8ecf5e9b472467bc57c84676a (patch)
treed9cd014eb369b0fdd39ae342d72a6cc475a002ca /doc
parentd3bf41a4192bd2b66f9d77b81002646caa7c00ce (diff)
downloadikiwiki-e68756dc789b45b8ecf5e9b472467bc57c84676a.tar
ikiwiki-e68756dc789b45b8ecf5e9b472467bc57c84676a.tar.gz
review
Diffstat (limited to 'doc')
-rw-r--r--doc/todo/Set_templates_for_whole_sections_of_the_site.mdwn22
1 files changed, 22 insertions, 0 deletions
diff --git a/doc/todo/Set_templates_for_whole_sections_of_the_site.mdwn b/doc/todo/Set_templates_for_whole_sections_of_the_site.mdwn
index 0dbda8a3a..1fa710f8f 100644
--- a/doc/todo/Set_templates_for_whole_sections_of_the_site.mdwn
+++ b/doc/todo/Set_templates_for_whole_sections_of_the_site.mdwn
@@ -39,3 +39,25 @@ I've written a new plugin, sectiontemplate, available in the `page_tmpl` branch
>>>>> --[[KathrynAndersen]]
Just a quick note that Kathryn's branch is ready.[[!template id=gitbranch branch=rubykat/pagetemplate author="[[KathrynAndersen]]"]][[!tag patch]] --[[Will]]
+
+> Review:
+>
+> The indentation seems odd. IkiWiki is mostly indented with hard tabs;
+> this seems to be a mixture of tabs and spaces, assuming 4 spaces per tab.
+>
+> [[!format perl """
+sub checkconfig () {
+...
+ ! defined IkiWiki::template_file($tmpl))
+"""]]
+>
+> I think `checkconfig` is too soon to rely on `template_file`
+> producing correct results? It looks in `%pagesources` which has not
+> yet been updated.
+>
+> If we had a "just before building" hook, that would be a good time
+> to emit warnings; or doing it once per run, on-demand, triggered
+> by the first call to the `templatefile` hook could work. Or the
+> hook could just silently ignore bad pagespecs?
+>
+> --[[smcv]]