aboutsummaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorhttps://www.google.com/accounts/o8/id?id=AItOawmUWmB1M35_jviFvGPYDIH-a-_Al-7OrXM <Daniel@web>2011-07-15 21:09:39 -0400
committeradmin <admin@branchable.com>2011-07-15 21:09:39 -0400
commitcb5aa7d63f07ba25ab3d162ea07676420dcd049a (patch)
tree641cac858e385d9230d841e375d63ff7d17c3ca8 /doc
parent17f12763db2c14f92f56bcd6e194412d0c4c9a89 (diff)
downloadikiwiki-cb5aa7d63f07ba25ab3d162ea07676420dcd049a.tar
ikiwiki-cb5aa7d63f07ba25ab3d162ea07676420dcd049a.tar.gz
Diffstat (limited to 'doc')
-rw-r--r--doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn24
1 files changed, 24 insertions, 0 deletions
diff --git a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
new file mode 100644
index 000000000..0e9d61398
--- /dev/null
+++ b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
@@ -0,0 +1,24 @@
+When I added or edited a page, no commit message was written out (Mercurial backend, though I guess it shouldn't matter). This was done for e.g. the `rename` plugin. I made a naive but seemingly working change to `editpage.pm` to add a message.
+
+I modeled the message on `rename.pm`, which used a lowercase initial letter and imperative form of the verb. This is not the case for e.g. the `comment` plugin, which says "Added a comment: ", so I guess there is no strict rule on style in this case.
+
+Diff follows. --[[Daniel Andersson]]
+
+[[!tag patch]]
+
+---
+
+ diff -r ee177ca9bf36 Plugin/editpage.pm
+ --- a/Plugin/editpage.pm Fri Jul 15 17:58:04 2011 +0200
+ +++ b/Plugin/editpage.pm Sat Jul 16 03:01:13 2011 +0200
+ @@ -405,6 +405,10 @@
+ if ($config{rcs}) {
+ if (! $exists) {
+ rcs_add($file);
+ + $message = "add $file";
+ + }
+ + else {
+ + $message = "edit $file";
+ }
+
+ # Prevent deadlock with post-commit hook by