aboutsummaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2010-11-22 14:05:37 -0400
committerJoey Hess <joey@kitenet.net>2010-11-22 14:06:41 -0400
commit178d6a16c2fff68edfbe6a1af5c8a9fa91db6039 (patch)
tree6cd3adc5c91cfba086bb356458be1e41eeb80973 /doc
parenta6c3d71787c528888c3f66c7ded8dd0c8f430b7e (diff)
downloadikiwiki-178d6a16c2fff68edfbe6a1af5c8a9fa91db6039.tar
ikiwiki-178d6a16c2fff68edfbe6a1af5c8a9fa91db6039.tar.gz
comments (finally)
Diffstat (limited to 'doc')
-rw-r--r--doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn17
1 files changed, 17 insertions, 0 deletions
diff --git a/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn b/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
index 20d22b9ab..4fafc2bbc 100644
--- a/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
+++ b/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
@@ -181,6 +181,16 @@ New API added by this branch:
* `urlto(x, y, 'local')` uses `$local_url` instead of `$config{url}`
+ > Yikes. I see why you wanted to keep it to 3 parameters (4 is too many,
+ > and po overrides it), but I dislike overloading the third parameter
+ > like that.
+ >
+ > There are fairly few calls to `urlto($foo, $bar)`, so why not
+ > make that always return the semi-local url form, and leave the third
+ > parameter for the cases that need a true fully-qualified url.
+ > The new form for local urls will typically be only a little bit longer,
+ > except in the unusual case where the cgiurl is elsewhere. --[[Joey]]
+
* `IkiWiki::baseurl` has a new second argument which works like the
third argument of `urlto`
@@ -199,9 +209,13 @@ Bugs:
`cgiurl(cgiurl => $config{cgiurl}, ...)`,
although that does look a bit strange
+ > I agree that makes sense. --[[Joey]]
+
* It occurs to me that `IkiWiki::cgiurl` could probably benefit from being
exported? Perhaps also `IkiWiki::baseurl`?
+ > Possibly, see [[firm_up_plugin_interface]]. --[[Joey]]
+
* Or, to reduce use of the unexported `baseurl` function, it might make
sense to give `urlto` a special case that references the root of the wiki,
with a trailing slash ready to append stuff: perhaps `urlto('/')`,
@@ -210,3 +224,6 @@ Bugs:
do_something(baseurl => urlto('/', undef, local)`);
do_something_else(urlto('/').'style.css');
IkiWiki::redirect(urlto('/', undef, 1));
+
+ > AFACIS, `baseurl` is only called in 3 places so I don't think that's
+ > needed. --[[Joey]]