aboutsummaryrefslogtreecommitdiff
path: root/doc/todo
diff options
context:
space:
mode:
authorhttp://www.cse.unsw.edu.au/~willu/ <http://www.cse.unsw.edu.au/~willu/@web>2009-08-16 09:01:12 -0400
committerJoey Hess <joey@kitenet.net>2009-08-16 09:01:12 -0400
commitd3ec1a3af2f9a2265336ba376f3ee7b75bb6e534 (patch)
tree73b87ba1a5942b78b350066891243c4e3d56e699 /doc/todo
parent216f5b5b203ca3ea9ddb3f6d8c2e03dae35aeb7e (diff)
downloadikiwiki-d3ec1a3af2f9a2265336ba376f3ee7b75bb6e534.tar
ikiwiki-d3ec1a3af2f9a2265336ba376f3ee7b75bb6e534.tar.gz
comment on part of Joey's comment
Diffstat (limited to 'doc/todo')
-rw-r--r--doc/todo/should_optimise_pagespecs.mdwn8
1 files changed, 8 insertions, 0 deletions
diff --git a/doc/todo/should_optimise_pagespecs.mdwn b/doc/todo/should_optimise_pagespecs.mdwn
index 1919e3584..9d2611249 100644
--- a/doc/todo/should_optimise_pagespecs.mdwn
+++ b/doc/todo/should_optimise_pagespecs.mdwn
@@ -120,6 +120,14 @@ separate item, the list can get rather long, and that single add_depends
loop has suddenly become O(N^2) to the number of pages, which is something
to avoid..
+> I was also thinking about this (I've been playing with some stuff based on the
+> `remove-pagespec-merge` branch). A hash, by itself, is not optimal because
+> the dependency list holds two things: page names and page specs. The hash would
+> work well for the page names, but you'll still need to iterate through the page specs.
+> I was thinking of keeping a list and a hash. You use the list for pagespecs
+> and the hash for individual page names. To make this work you need to adjust the
+> API so it knows which you're adding. -- [[Will]]
+
Also, since a lot of places are calling add_depends in a loop, it probably
makes sense to just make it accept a list of dependencies to add. It'll be
marginally faster, probably, and should allow for better optimisation