aboutsummaryrefslogtreecommitdiff
path: root/doc/todo
diff options
context:
space:
mode:
authorhttps://www.google.com/accounts/o8/id?id=AItOawmUWmB1M35_jviFvGPYDIH-a-_Al-7OrXM <Daniel@web>2011-07-19 12:18:51 -0400
committeradmin <admin@branchable.com>2011-07-19 12:18:51 -0400
commit758a4c23fd0fc30b89739f0d2be7bf0fe2f81be8 (patch)
treeb982a9f309d772b2c44af0177ff51fed8044fd18 /doc/todo
parent8786fbfbbcb8c0a860e4ed90abda3114df45544b (diff)
downloadikiwiki-758a4c23fd0fc30b89739f0d2be7bf0fe2f81be8.tar
ikiwiki-758a4c23fd0fc30b89739f0d2be7bf0fe2f81be8.tar.gz
Diffstat (limited to 'doc/todo')
-rw-r--r--doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn6
1 files changed, 5 insertions, 1 deletions
diff --git a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
index c7438feb6..571e1a6eb 100644
--- a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
+++ b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
@@ -9,10 +9,14 @@ Diff follows. --[[Daniel Andersson]]
> itself and it would just be clutter to mention what file was changed,
> since any reasonable interface will show the filename, or a link,
> or some summary of what files were affected when showing a change.
->
+
+>> I use the Mercurial backend, and Mercurial doesn't allow empty commit messages, so if there were no message, it would default to "no message given" (hardcoded in `mercurial.pm`), which is also clutter, and non-descriptive at that. But I'm on board with your reasoning. It's a matter of taste (and somewhat backend), I guess. I might continue to locally use this patch (with the caveat below fixed when commit message is given), but I won't push for it to be included upstream. --[[Daniel Andersson]]
+
> Also your patch stomps over any commit message that the user *does*
> provide, so certianly cannot be applied as-is. --[[Joey]]
+>> Yes, "naive" was the word :-) . --[[Daniel Andersson]]
+
[[!tag patch]]
---