aboutsummaryrefslogtreecommitdiff
path: root/doc/todo
diff options
context:
space:
mode:
authorintrigeri <intrigeri@web>2018-07-06 12:56:25 -0400
committeradmin <admin@branchable.com>2018-07-06 12:56:25 -0400
commit302221698c45d257856ec225302f3d13c66e18bb (patch)
treeb922ba3670e4732c6130fcdde757c9237ca86f8b /doc/todo
parent6a026338bbb728f7fc3dda16ba0fe9c9b4255514 (diff)
downloadikiwiki-302221698c45d257856ec225302f3d13c66e18bb.tar
ikiwiki-302221698c45d257856ec225302f3d13c66e18bb.tar.gz
Reviewed patch.
Diffstat (limited to 'doc/todo')
-rw-r--r--doc/todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn2
1 files changed, 2 insertions, 0 deletions
diff --git a/doc/todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn b/doc/todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn
index 591c0b231..037b5925d 100644
--- a/doc/todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn
+++ b/doc/todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn
@@ -85,3 +85,5 @@
2.18.0
[[!tag patch]]
+
+> Thank you Chris! I've reviewed the patch (with my "original author of the po plugin" hat on) and it looks good to me. I'm not 100% sure about `alreadyfiltered` being the best name for something that's not a predicated anymore but it's good enough. Then I wore my end-user hat and confirmed that with Chris' patch applied, the reproducer we had for this bug at Tails works fine. So IMO we're good to go and I recommend to apply this patch. Thanks in advance! -- [[intrigeri]]