aboutsummaryrefslogtreecommitdiff
path: root/doc/todo
diff options
context:
space:
mode:
authorJoey Hess <joey@gnu.kitenet.net>2009-01-26 19:41:35 -0500
committerJoey Hess <joey@gnu.kitenet.net>2009-01-26 19:41:35 -0500
commit16ff246d4112fd208189a05f7b64a6d0dbe53132 (patch)
treebf9a792f2c4bd6fa922a982338f71cab5dffe5e8 /doc/todo
parenteb9c05e18cb7880a402c76dc86b652ca381c8d7a (diff)
downloadikiwiki-16ff246d4112fd208189a05f7b64a6d0dbe53132.tar
ikiwiki-16ff246d4112fd208189a05f7b64a6d0dbe53132.tar.gz
rename hook issues
Diffstat (limited to 'doc/todo')
-rw-r--r--doc/todo/need_global_renamepage_hook.mdwn18
1 files changed, 18 insertions, 0 deletions
diff --git a/doc/todo/need_global_renamepage_hook.mdwn b/doc/todo/need_global_renamepage_hook.mdwn
index 7af2bdc56..62e91eee4 100644
--- a/doc/todo/need_global_renamepage_hook.mdwn
+++ b/doc/todo/need_global_renamepage_hook.mdwn
@@ -62,3 +62,21 @@ would solve my problem. Hmmm? --[[intrigeri]]
>>> is, and call `rename` the global hook I need. --[[intrigeri]]
>>>> Done in my `po` branch. --[[intrigeri]]
+
+I think I see a problem in the rename hook. The hook is called
+before the plugin adds any subpages to the set of pages to rename.
+So, if the user choses to rename subpages, po will not notice
+they are moving, and will not move their po files.
+
+Perhaps the hooks should be moved to come after subpages are added.
+This would, though, mean that if the hook somehow decides to add
+entirely other pages to the list, their subpages would not be
+automatically added.
+
+I also have some qualms about the design of the hook. In particular,
+passing the mutable array reference probably makes it impossible
+to use from external plugins. Instead it could return any additional
+rename hashes it wants to add. Or, if the ability to modify existing
+hashes is desired, it could return the full set of hashes.
+
+--[[Joey]]