diff options
| author | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2007-08-17 01:02:54 +0000 |
|---|---|---|
| committer | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2007-08-17 01:02:54 +0000 |
| commit | 2d244b95a2809d416b7df91789d498b769e2bd13 (patch) | |
| tree | eff76fa09d6671f26e0bd364a861d2ba1efc2d69 /doc/todo/preview_changes.mdwn | |
| parent | 52cd9ae4bb891efb73a999d02dc2dffa0fc083be (diff) | |
| download | ikiwiki-2d244b95a2809d416b7df91789d498b769e2bd13.tar ikiwiki-2d244b95a2809d416b7df91789d498b769e2bd13.tar.gz | |
web commit by http://jeremie.koenig.myopenid.com/: remove my notes, relevant stuff moved to plugins/contrib/showdiff
Diffstat (limited to 'doc/todo/preview_changes.mdwn')
| -rw-r--r-- | doc/todo/preview_changes.mdwn | 29 |
1 files changed, 2 insertions, 27 deletions
diff --git a/doc/todo/preview_changes.mdwn b/doc/todo/preview_changes.mdwn index 5b77981a6..dc19a0d73 100644 --- a/doc/todo/preview_changes.mdwn +++ b/doc/todo/preview_changes.mdwn @@ -7,31 +7,6 @@ Some discussion from the main [[/index/discussion]] page: > >> It's doable, it could even be done by a [[todo/plugin]], I think. >> --[[Joey]] +>> ---- - -I need help with this. Supposedly, such a plugin would provide a `formbuilder_setup` -hook which would add the button, and a cgi hook which would interecept -"Show Diff" clicks. This would show a diff between -`titlepage(possibly_foolish_untaint($form->field("page")))` -and the provided `$form->field("editcontent")`. - -But: - - * How could the case of concurrent editing be handled ? - Especially as (I think) only the RCS backend can know that - this has happened. - * May I hijack the `page_preview` template variable to show - my diff output? (the patch below assumes this). - * Using the formbuilder hook to add a button, and coerce `editpage()` - into showing the edit form again rather that saving the page needs - the following patch. (note that this is not the only template which has - its submit buttons hardcoded; is this supposed to work around something?) - -I've got a [preliminary implementation](http://www.jk.fr.eu.org/ikiwiki/showdiff.pm), -which depends on [this patch](http://www.jk.fr.eu.org/ikiwiki/pluggable_editpage_buttons.diff) -and the [[plugins/contrib/plaintext]] plugin. - -There is still some tweaking needed, though. - ---[[JeremieKoenig]]
\ No newline at end of file +See the [[plugins/contrib/showdiff]] plugin --[[JeremieKoenig]] |