diff options
| author | spalax <spalax@web> | 2014-11-14 10:05:03 -0400 |
|---|---|---|
| committer | admin <admin@branchable.com> | 2014-11-14 10:05:03 -0400 |
| commit | 062a915d7b5e4a6fcbfcca243d02a6aa9c4222ee (patch) | |
| tree | ca66d6661f5b702f33e9f619c6f448559bea0e9a /doc/todo/calendar_autocreate.mdwn | |
| parent | 58b848bc5844cfa632c26909f32abbf275d1e0d4 (diff) | |
| download | ikiwiki-062a915d7b5e4a6fcbfcca243d02a6aa9c4222ee.tar ikiwiki-062a915d7b5e4a6fcbfcca243d02a6aa9c4222ee.tar.gz | |
Amendment, following review
Diffstat (limited to 'doc/todo/calendar_autocreate.mdwn')
| -rw-r--r-- | doc/todo/calendar_autocreate.mdwn | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/doc/todo/calendar_autocreate.mdwn b/doc/todo/calendar_autocreate.mdwn index 2a7350b79..371079d68 100644 --- a/doc/todo/calendar_autocreate.mdwn +++ b/doc/todo/calendar_autocreate.mdwn @@ -191,22 +191,30 @@ sub gencalendaryear { > > I think that should be `ikiwiki --setup ~/ikiwiki.setup --refresh` > +> > [[Corrected|https://github.com/paternal/ikiwiki/commit/213dad76d47bab9db8e44d6e20c8371960375e77]] +> > The indentation of some of the new code in `IkiWiki/Plugin/calendar.pm` > is weird. Please use one hard tab (U+0009) per indent step: you seem > to have used a mixture of one hard tab per indent or two spaces > per indent, which looks bizarre for anyone whose tab size is not > 2 spaces. > +> > [[Corrected|https://github.com/paternal/ikiwiki/commit/1d97160dae775c31e166d9886472dacdd773d571]] +> > + return unless $config{calendar_autocreate}; > > This is checked in `gencalendaryear` but not in `gencalendarmonth`. > Shouldn't `gencalendarmonth` do it too? Alternatively, do the check > in `scan`, which calls `gencalendarmonth` directly. > +> > Once again, [[you are right|https://github.com/paternal/ikiwiki/commit/473bcbe7a42a4168cab82ed12185817248de045f]] +> > + my $year = $date[5] + 1900; > > You calculate this, but you don't seem to do anything with it? > +> > [[Corrected|https://github.com/paternal/ikiwiki/commit/d0b34951240317642543351ec62f98d3d8df8c0f]] +> > + if (not exists $changed{$params{year}}) { > + $changed{$params{year}} = (); > + } @@ -222,4 +230,9 @@ sub gencalendaryear { > in order to put the pair `$params{month} => 1` in it (the term to look > up if you're curious is "autovivification"). > +> > [[Corrected|https://github.com/paternal/ikiwiki/commit/d0b34951240317642543351ec62f98d3d8df8c0f]] +> > --[[smcv]] +> +> > Thank you for your review. +> > --[[Louis|spalax]] |