aboutsummaryrefslogtreecommitdiff
path: root/doc/todo/be_more_selective_about_running_hooks.mdwn
diff options
context:
space:
mode:
authorhttp://cgray.myopenid.com/ <cgray@web>2012-02-13 13:43:06 -0400
committeradmin <admin@branchable.com>2012-02-13 13:43:06 -0400
commit24bdab75e379c5a542d9e07bc0997ee16cef992d (patch)
tree9b8944751a12ed8f90225c173d84d22d36e5b289 /doc/todo/be_more_selective_about_running_hooks.mdwn
parent779e9228149b35de3722cd4863380d7aad6e2fe4 (diff)
downloadikiwiki-24bdab75e379c5a542d9e07bc0997ee16cef992d.tar
ikiwiki-24bdab75e379c5a542d9e07bc0997ee16cef992d.tar.gz
Diffstat (limited to 'doc/todo/be_more_selective_about_running_hooks.mdwn')
-rw-r--r--doc/todo/be_more_selective_about_running_hooks.mdwn14
1 files changed, 14 insertions, 0 deletions
diff --git a/doc/todo/be_more_selective_about_running_hooks.mdwn b/doc/todo/be_more_selective_about_running_hooks.mdwn
index 429647712..70a1cb7a2 100644
--- a/doc/todo/be_more_selective_about_running_hooks.mdwn
+++ b/doc/todo/be_more_selective_about_running_hooks.mdwn
@@ -12,6 +12,11 @@ only do anything if they do.
> something else, it has no reason to care what the pagetype is. (Same for
> linkify.) --[[Joey]]
+>> My [[org-mode|todo/org_mode]] external plugin (which will never
+>> really make sense to include with ikiwiki I think) does this. I
+>> think that most plugins defining alternate wiki syntaxes would as
+>> well. --[[chrismgray]]
+
This is a bit wasteful in itself, but for external plugins, it's
really bad. For functions like `scan` and `linkify`, where the entire
page is sent back and forth over `stdout` and `stdin`, it really slows
@@ -52,3 +57,12 @@ best name.
>>>> it's really the overhead of serializing the page content, that's
>>>> the problem, and not just the general overhead of making rpc calls
>>>> for every page.. --[[Joey]]
+
+>>>>> Since the argument to `hook` is optional, the pagespec is only
+>>>>> interpreted if it is given. So there is no extra overhead
+>>>>> (beyond an unused `if` branch) in 99% of the cases.
+>>>>>
+>>>>> Rewriting the external plugin's shim using Perl is a good idea,
+>>>>> and one that I wish I had thought of earlier. On the other
+>>>>> hand, it doesn't set a great precedent about the usability of
+>>>>> external plugins. --[[chrismgray]]