diff options
author | chrysn <chrysn@web> | 2013-08-10 08:48:50 -0400 |
---|---|---|
committer | admin <admin@branchable.com> | 2013-08-10 08:48:50 -0400 |
commit | ecc9dd10068f534644d858c54109969f5c9d12d7 (patch) | |
tree | e1fd4e1c8b15f738d8e607c8a858cb81fcda5742 /doc/bugs | |
parent | b140745662d71b829c995aa1d7dc290048867a8a (diff) | |
download | ikiwiki-ecc9dd10068f534644d858c54109969f5c9d12d7.tar ikiwiki-ecc9dd10068f534644d858c54109969f5c9d12d7.tar.gz |
raise recursion limit to 8
Diffstat (limited to 'doc/bugs')
-rw-r--r-- | doc/bugs/preprocessing_loop_control_too_tight.mdwn | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/doc/bugs/preprocessing_loop_control_too_tight.mdwn b/doc/bugs/preprocessing_loop_control_too_tight.mdwn new file mode 100644 index 000000000..f1a9bc9a7 --- /dev/null +++ b/doc/bugs/preprocessing_loop_control_too_tight.mdwn @@ -0,0 +1,19 @@ +the preprocessing hook makes sure that no infinite loops occur by restricting the depth of nested directives to 3. + +this is insufficient in some situations in which sidebars are conditionally assembled from templates. + +given there are no limits on the number of directives per page and the number of edits a user can do in a particular time frame, i assume that raising that limit slightly won't make the DoS attacks that can be done against ikiwiki too much worse. + +i'd like to suggest 8 as a new value for recursion depth limit. most people can wrap their minds around a depth 3 nested directive setup, but when you reach a depth of 8, it's likely to be easier to write a dedicated plugin. + +<code><pre> +diff --git a/IkiWiki.pm b/IkiWiki.pm +index 75c9579..ad0f8b0 100644 +--- a/IkiWiki.pm ++++ b/IkiWiki.pm +@@ -1487 +1487 @@ sub preprocess ($$$;$$) { +- if ($preprocessing{$page}++ > 3) { ++ if ($preprocessing{$page}++ > 8) { +</pre></code> + +[[!tag patch]] |