aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs
diff options
context:
space:
mode:
authorsmcv <smcv@web>2019-01-31 16:38:04 -0400
committeradmin <admin@branchable.com>2019-01-31 16:38:04 -0400
commitdbf9a362976edf6e97ff826915a58c93b77784c1 (patch)
tree3a5a096fd37401e0c338e21a9f8d1400ca840eee /doc/bugs
parentf3103c9d092fd11747d50c049213b0f152523e09 (diff)
downloadikiwiki-dbf9a362976edf6e97ff826915a58c93b77784c1.tar
ikiwiki-dbf9a362976edf6e97ff826915a58c93b77784c1.tar.gz
I'm confused about what the bug is, and what's being fixed. Can you give a complete test or example?
Diffstat (limited to 'doc/bugs')
-rw-r--r--doc/bugs/About___37__2F_problem.mdwn37
1 files changed, 35 insertions, 2 deletions
diff --git a/doc/bugs/About___37__2F_problem.mdwn b/doc/bugs/About___37__2F_problem.mdwn
index f855485d2..15f64b883 100644
--- a/doc/bugs/About___37__2F_problem.mdwn
+++ b/doc/bugs/About___37__2F_problem.mdwn
@@ -62,6 +62,39 @@ not deal with Chinese char, the below link can work
--
2.19.0
+---
-
-
+> Please could you try to make a minimal example or test, perhaps in the [[sandbox]]
+> on this wiki or as a unit test in `t/git-cgi.t` in the ikiwiki source code, that
+> demonstrates this bug and would be fixed by your patch? I tried to write a test
+> for this, and I was able to make a test that uses a UTF-8 `rootpage` and fails;
+> but your patch doesn't seem to fix it, so you must be seeing something different.
+> I think there might be more than one bug here.
+>
+> If you've found multiple bugs, a separate example or test for each one would be
+> easiest to deal with.
+>
+> In your original report, you said the `rootpage` was ASCII and started with `./`:
+> `./bugs`. Then you mentioned Chinese characters (any non-ASCII character like é or ¬
+> should behave the same as Chinese here) and attached a patch that alters how those
+> are handled, without affecting what would happen to a `rootpage` that starts
+> with `./`; so I'm confused about what the bug was, and what you are fixing?
+>
+> I've added tests to `t/git-cgi.t` which demonstrate a blog form for a `rootpage`
+> named `writable/blog` working correctly (which passes), and a `rootpage` named
+> `writable/¬blog` not working correctly (which fails, and is marked as *TODO*).
+> The patch above doesn't seem to make the second new test pass.
+>
+> You can run all the tests with:
+>
+> ./Makefile.PL
+> make
+> make test
+>
+> or a single test with something like:
+>
+> ./Makefile.PL
+> make
+> PERL5LIB=. ./t/git-cgi.t
+>
+> --[[smcv]]