diff options
| author | Simon McVittie <smcv@debian.org> | 2018-12-01 21:18:23 +0000 |
|---|---|---|
| committer | Simon McVittie <smcv@debian.org> | 2019-02-24 17:23:34 +0000 |
| commit | 824cf7db1b96a16b080e284bc3ebf90c1f14a203 (patch) | |
| tree | 2362c20b87d5d434ce6e4e8c3790f5c795299693 /doc/bugs | |
| parent | 94486851176765d5fac2992256039647605976f3 (diff) | |
| download | ikiwiki-824cf7db1b96a16b080e284bc3ebf90c1f14a203.tar ikiwiki-824cf7db1b96a16b080e284bc3ebf90c1f14a203.tar.gz | |
po: Always filter .po files
The input to filter hooks is meant to be the content of a source file
on disk. If we only filter once per (page, destpage) pair, and a page
is inlined into the same destpage more than once, then the second
occurrence will render as the result of htmlizing .po source as if
it was Markdown (or whatever the type of the corresponding master page
is), which is never going to end well.
The alreadyfiltered mechanism was added in commit 1e874b3f to avoid
preprocessing loops, but I'm not sure where it could lead to a loop:
filter hooks are only called from IkiWiki::filter, which is only called
on page content from disk or on proposed content being previewed.
According to <https://bugs.debian.org/911356#41>, deleting the
alreadyfiltered mechanism resolves the problem, as well as simplifying
the code.
Closes: #911356
Tested-by: intrigeri
Diffstat (limited to 'doc/bugs')
| -rw-r--r-- | doc/bugs/po:_second_or_subsequent_inline_of_translated_page_inlines_.po_file__44___not_translated_content.mdwn | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/bugs/po:_second_or_subsequent_inline_of_translated_page_inlines_.po_file__44___not_translated_content.mdwn b/doc/bugs/po:_second_or_subsequent_inline_of_translated_page_inlines_.po_file__44___not_translated_content.mdwn index a926135b0..26d3717b9 100644 --- a/doc/bugs/po:_second_or_subsequent_inline_of_translated_page_inlines_.po_file__44___not_translated_content.mdwn +++ b/doc/bugs/po:_second_or_subsequent_inline_of_translated_page_inlines_.po_file__44___not_translated_content.mdwn @@ -177,3 +177,6 @@ be resolved by renaming. If it's valid to remove the `alreadyfiltered` mechanism, my `wip/po-filter-every-time` branch does that. Please test? + +> intrigeri says [this change works as intended on tails.org](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911356#41), +> so I've applied it. [[done]] --[[smcv]] |