aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs
diff options
context:
space:
mode:
authorJoey Hess <joey@gnu.kitenet.net>2009-11-08 13:48:07 -0500
committerJoey Hess <joey@gnu.kitenet.net>2009-11-08 13:48:07 -0500
commit66b46576ec097b9f10b45d4b1de18bb214cd5bd5 (patch)
tree9cda888650586e576da95dd5eaa28bb1ec80991d /doc/bugs
parent19ff6180a8bbb2e5441fe177a934e146d129f1c7 (diff)
downloadikiwiki-66b46576ec097b9f10b45d4b1de18bb214cd5bd5.tar
ikiwiki-66b46576ec097b9f10b45d4b1de18bb214cd5bd5.tar.gz
Moved the postscan hook to run on the raw html of a page, before the template is filled out. This improves the search plugin's indexing, since it will not include navigational elements from the page template or sidebar.
Diffstat (limited to 'doc/bugs')
-rw-r--r--doc/bugs/Search_summary_includes_text_from_navigational_elements.mdwn13
1 files changed, 13 insertions, 0 deletions
diff --git a/doc/bugs/Search_summary_includes_text_from_navigational_elements.mdwn b/doc/bugs/Search_summary_includes_text_from_navigational_elements.mdwn
index 874b9ffeb..b774c4531 100644
--- a/doc/bugs/Search_summary_includes_text_from_navigational_elements.mdwn
+++ b/doc/bugs/Search_summary_includes_text_from_navigational_elements.mdwn
@@ -7,3 +7,16 @@ A way to name some CSS ids that should be removed in search results within the i
http://leaf.dragonflybsd.org/mailarchive/users/2009-11/msg00077.html
(bin attachment on that page is actually a .diff.)
+
+> So I was looking at this and I relized that while the search plugin used
+> to use the format hook, and so there was no way to avoid it seeing all
+> the gunk around the page body, it was changed a while ago for different
+> reasons to use its own hook, postscan. So there's really no reason not
+> to move postscan so it runs before said gunk is added to the page.
+> (Aside from a small risk of breaking other third-party plugins that
+> somehow use postscan.)
+>
+> I've implemented that in git, and it drops the navigation elements nicely.
+> It's perhaps less general than allowing specific divs to be skipped from
+> search, but it seems good enough. Please thank the dragonfly guys for their
+> work on this. [[done]] --[[Joey]]