diff options
| author | Simon McVittie <smcv@debian.org> | 2019-02-03 13:19:57 +0000 |
|---|---|---|
| committer | Simon McVittie <smcv@debian.org> | 2019-02-03 13:27:00 +0000 |
| commit | 4ba3c1159272c8070d5dc962ff1634ad6ba21618 (patch) | |
| tree | 1486039d8b82a7dd1b085d707f7d51c76c27d779 /doc/bugs | |
| parent | e8dea1b9241b35217d9727be4f4460a8b562bbb3 (diff) | |
| download | ikiwiki-4ba3c1159272c8070d5dc962ff1634ad6ba21618.tar ikiwiki-4ba3c1159272c8070d5dc962ff1634ad6ba21618.tar.gz | |
git-cgi.t: Exercise an alphanumeric, but non-ASCII, root page
My previous attempt to reproduce this bug used a non-alphanumeric
ASCII character. This is not currently considered to be a valid
value for rootpage, although for a "do what I mean" approach, perhaps
we should accept it and pass it through titlepage() or linkpage().
Using Chinese characters (which are considered to match [[:alnum:]]
even though the Chinese script is not, strictly speaking, an alphabet),
as in the original bug report, reproduces the bug.
Signed-off-by: Simon McVittie <smcv@debian.org>
Diffstat (limited to 'doc/bugs')
| -rw-r--r-- | doc/bugs/About___37__2F_problem.mdwn | 31 |
1 files changed, 12 insertions, 19 deletions
diff --git a/doc/bugs/About___37__2F_problem.mdwn b/doc/bugs/About___37__2F_problem.mdwn index 29879e9f0..d45325711 100644 --- a/doc/bugs/About___37__2F_problem.mdwn +++ b/doc/bugs/About___37__2F_problem.mdwn @@ -64,28 +64,21 @@ not deal with Chinese char, the below link can work --- -> Please could you try to make a minimal example or test, perhaps in the [[sandbox]] -> on this wiki or as a unit test in `t/git-cgi.t` in the ikiwiki source code, that -> demonstrates this bug and would be fixed by your patch? I tried to write a test -> for this, and I was able to make a test that uses a UTF-8 `rootpage` and fails; -> but your patch doesn't seem to fix it, so you must be seeing something different. -> I think there might be more than one bug here. +> [Request for clarification removed] > -> If you've found multiple bugs, a separate example or test for each one would be -> easiest to deal with. +> I've now been able to reproduce this bug, and confirmed that your patch +> fixes it. [[Patch now applied|done]]. > -> In your original report, you said the `rootpage` was ASCII and started with `./`: -> `./bugs`. Then you mentioned Chinese characters (any non-ASCII character like é or ¬ -> should behave the same as Chinese here) and attached a patch that alters how those -> are handled, without affecting what would happen to a `rootpage` that starts -> with `./`; so I'm confused about what the bug was, and what you are fixing? +> (For other maintainers' reference: when testing Unicode bugs that +> relate to page titles, using Unicode that is considered to be +> punctuation, like ¬ or emoji, will probably not work; page titles +> treat `[:alnum:]` and `^[:alnum:]` differently.) > -> I've added tests to `t/git-cgi.t` which demonstrate -> [a blog form for a `rootpage` named `writable/blog` working correctly](http://source.ikiwiki.branchable.com/?p=source.git;a=commitdiff;h=9c0694b14c0c8ed0dee4ff4ed57f689919707cd7;hp=a10d86bbaebee2d6a30b66b4366d3f0247264678) -> (which passes), and -> [a `rootpage` named `writable/¬blog` not working correctly](http://source.ikiwiki.branchable.com/?p=source.git;a=commitdiff;h=2bd72cd0e01b8bb433b368e11ff9db779a21ccef;hp=9c0694b14c0c8ed0dee4ff4ed57f689919707cd7) -> (which fails, and is marked as *TODO*). -> The patch above doesn't seem to make the second new test pass. +> In future bug reports it would be useful if you could provide a minimal +> example or test, perhaps on the [[sandbox]] on this wiki or as a unit +> test in `t/*.t` in the ikiwiki source code, that demonstrates this bug +> and would be fixed by the patch. If you've found multiple bugs, a +> separate example or test for each one would be easiest to deal with. > > You can run all the tests with: > |