diff options
| author | http://smcv.pseudorandom.co.uk/ <smcv@web> | 2010-12-20 23:08:14 +0000 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2010-12-20 23:08:14 +0000 |
| commit | f83fa962d5a7d43eed5d0902771365b717b224b4 (patch) | |
| tree | c8b1361224c0733b4a710c84d05709ce8c8bb780 /doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn | |
| parent | 4d93407e19d553a5c62cb8b7ae4f2a0b3fbefbfb (diff) | |
| download | ikiwiki-f83fa962d5a7d43eed5d0902771365b717b224b4.tar ikiwiki-f83fa962d5a7d43eed5d0902771365b717b224b4.tar.gz | |
looks good to merge, suggestions for further testing
Diffstat (limited to 'doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn')
| -rw-r--r-- | doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn b/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn index 07e925a03..9690b8b7b 100644 --- a/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn +++ b/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn @@ -3,9 +3,25 @@ signature changes. Else a wiki with the po plugin enabled cannot be refreshed / rebuilt because of (correct) Perl errors. My po branch contains a fix. +--[[intrigeri]] + +> The commit looks sane to me, for what it's worth. Joey, please +> consider merging? --[[smcv]] Also, I fear the lack of any useful `$from` parameter might break some l10n'd link niceness when using `po_link_to = current` but I have not investigated this yet. - --[[intrigeri]] + +> If `urlto` is called without a second parameter, it means we need +> a URL valid from either the CGI URL or any page in the wiki, +> (so we'd previously have set the third parameter true), but we +> don't *necessarily* need an absolute URL - so return what you'd +> have returned if asked for an absolute URL, but looking like +> `/bugs/` rather than `http://ikiwiki.info/bugs/` if possible. +> +> It looks as though `beautify_urlpath` under `po_link_to = current`, +> and 3-argument `urlto`, aren't tested by `t/po.t` - perhaps you +> could add some test cases there? To test 3-argument `urlto` you'd +> need to add `$config{baseurl} = "http://example.com"` or +> something. --[[smcv]] |