aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs/recentchangesdiff_crashes_on_commits_which_remove_a_lot_of_files.mdwn
diff options
context:
space:
mode:
authorJoey Hess <joey@kodama.kitenet.net>2008-03-12 15:45:10 -0400
committerJoey Hess <joey@kodama.kitenet.net>2008-03-12 15:45:10 -0400
commit862ca19eb1aee87e4ac05e8a5a9b326dd32dfe5d (patch)
tree65d67b5398db4cae6fd0d57526ba907b1b002d2c /doc/bugs/recentchangesdiff_crashes_on_commits_which_remove_a_lot_of_files.mdwn
parent672893634be9d7e7f2b44c27e4927021b12eedb6 (diff)
downloadikiwiki-862ca19eb1aee87e4ac05e8a5a9b326dd32dfe5d.tar
ikiwiki-862ca19eb1aee87e4ac05e8a5a9b326dd32dfe5d.tar.gz
truncate recentchangesdiffs after 200 lines
This works around a perl crasher bug, and also avoids bloating pages with enormous diffs. rcs_recentchanges modified to return a list in an array context.
Diffstat (limited to 'doc/bugs/recentchangesdiff_crashes_on_commits_which_remove_a_lot_of_files.mdwn')
-rw-r--r--doc/bugs/recentchangesdiff_crashes_on_commits_which_remove_a_lot_of_files.mdwn21
1 files changed, 21 insertions, 0 deletions
diff --git a/doc/bugs/recentchangesdiff_crashes_on_commits_which_remove_a_lot_of_files.mdwn b/doc/bugs/recentchangesdiff_crashes_on_commits_which_remove_a_lot_of_files.mdwn
index 5872275b5..eaf6c95e9 100644
--- a/doc/bugs/recentchangesdiff_crashes_on_commits_which_remove_a_lot_of_files.mdwn
+++ b/doc/bugs/recentchangesdiff_crashes_on_commits_which_remove_a_lot_of_files.mdwn
@@ -23,3 +23,24 @@ The tarball is at http://scratch.madduck.net/__tmp__recentchanges-segfault.tgz -
rm -rf wc/recentchanges
ikiwiki --setup ikiwiki.setup
# works
+
+> I can reproduce it fine with that, thanks, and it's really looking like a
+> pure perl bug, that is triggered by markdown. Here's a simpler test case:
+
+ joey@kodama:/tmp>markdown < f
+ zsh: segmentation fault markdown < f
+
+> Where f is a 6.3 mb file that I
+> extracted from ikiwiki's rendering pipeline.
+
+> It seems to be crashing at markdown line 345, which is a big nasty
+> `s///` statement.
+
+> The good news: markdown version 1.0.2~b8-2 does not trigger this perl bug.
+> I only see it with 1.0.1. (Bad news: Newer versions of markdown are
+> slooooooow, especially on such large files.)
+
+> I'm calling this [[done]] since I've filed [[debbug 470676]] on perl, and
+> also have modified recentchangesdiff to only show the first 200 lines of
+> diff, which should be enough without bloating the recentchanges into
+> perl-crashing territory. --[[Joey]]