diff options
| author | smcv <smcv@web> | 2014-06-30 05:49:44 -0400 |
|---|---|---|
| committer | admin <admin@branchable.com> | 2014-06-30 05:49:44 -0400 |
| commit | c10c6c1c4db528877113ea808dbecb1cd3cd4682 (patch) | |
| tree | d38fedf1de41b6b513b7ee462b7083104a8b9213 /doc/bugs/pythonproxy-utf8_again.mdwn | |
| parent | a4d3db605a921b6c99d1b5082450090e31911afc (diff) | |
| download | ikiwiki-c10c6c1c4db528877113ea808dbecb1cd3cd4682.tar ikiwiki-c10c6c1c4db528877113ea808dbecb1cd3cd4682.tar.gz | |
review, suggest a change
Diffstat (limited to 'doc/bugs/pythonproxy-utf8_again.mdwn')
| -rw-r--r-- | doc/bugs/pythonproxy-utf8_again.mdwn | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/bugs/pythonproxy-utf8_again.mdwn b/doc/bugs/pythonproxy-utf8_again.mdwn index 14d5cb98e..b5564d6c1 100644 --- a/doc/bugs/pythonproxy-utf8_again.mdwn +++ b/doc/bugs/pythonproxy-utf8_again.mdwn @@ -34,3 +34,15 @@ patch. > it seems to me that the issue is related to the way exceptions are encoded. > > the suggested patch still applies and solves the issue. --[[chrysn]] + +>> In this patch band: +>> +>> - xml = _IkiWikiExtPluginXMLRPCHandler._read(in_fd).decode('utf8') +>> + response = _IkiWikiExtPluginXMLRPCHandler._read(in_fd) +>> + if isinstance(response, unicode): +>> + xml = response.encode('utf8') +>> +>> I think you mean `response.decode`, not `response.encode`. +>> +>> Other than that it looks good to me. I like the use of `repr` in debug +>> messages. --[[smcv]] |