aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs/mercurial_fail_to_add.mdwn
diff options
context:
space:
mode:
authorjoey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>2007-04-29 03:25:09 +0000
committerjoey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>2007-04-29 03:25:09 +0000
commit5c36a5cfc675ca4282c0a03ee444c43dea537fa9 (patch)
treefaeb6824939206186f1986caea67cd15b12a2f08 /doc/bugs/mercurial_fail_to_add.mdwn
parenta1d9abab8c1542d546c34fa03447d1f6456ba813 (diff)
downloadikiwiki-5c36a5cfc675ca4282c0a03ee444c43dea537fa9.tar
ikiwiki-5c36a5cfc675ca4282c0a03ee444c43dea537fa9.tar.gz
* Apply patch from hb that uses the full path to a file when adding a file
using the mercurial backend. Not 100% sure why it failed w/o the full path, but this still passes the test suite, and indeed, is how the test suite calls hg add.
Diffstat (limited to 'doc/bugs/mercurial_fail_to_add.mdwn')
-rw-r--r--doc/bugs/mercurial_fail_to_add.mdwn26
1 files changed, 26 insertions, 0 deletions
diff --git a/doc/bugs/mercurial_fail_to_add.mdwn b/doc/bugs/mercurial_fail_to_add.mdwn
new file mode 100644
index 000000000..d47960e9b
--- /dev/null
+++ b/doc/bugs/mercurial_fail_to_add.mdwn
@@ -0,0 +1,26 @@
+I don't know what's wrong but I can't add a file with the mercurial backend (the file is created but not added).
+
+Here is a patch that's seems to work, although I'm not quite sure what's wrong with current code :
+
+ hbernard@tactic:/usr/share/perl5/IkiWiki/Rcs$ diff mercurial.pm /home/hbernard/mercurial.pm -Nau
+ --- mercurial.pm 2007-03-24 16:14:35.000000000 +0100
+ +++ /home/hbernard/mercurial.pm 2007-04-19 19:05:47.000000000 +0200
+ @@ -95,7 +95,7 @@
+ sub rcs_add ($) { # {{{
+ my ($file) = @_;
+
+ - my @cmdline = ("hg", "-q", "-R", "$config{srcdir}", "add", "$file");
+ + my @cmdline = ("hg", "-q", "-R", "$config{srcdir}", "add", "$config{srcdir}/$file");
+ if (system(@cmdline) != 0) {
+ warn "'@cmdline' failed: $!";
+ }
+
+My srcdir path has some symbolics links and hidden directorys... maybe that's it ?
+
+> Interesting, the mercurial test suite shows the add without the path
+> working ok. OTOH, it also continues to work if I apply your patch, so I
+> guess it's safe enough. It would be good to know why it's failing w/o the
+> path in your case. --[[Joey]]
+
+> As I applied the patch, I'm moving this out of the patchqueue to bugs and
+> marking it [[done]]. --[[Joey]]