aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs/cannot_revert_page_deletion.mdwn
diff options
context:
space:
mode:
authorJoey Hess <joey@kitenet.net>2011-09-05 14:51:49 -0400
committerJoey Hess <joey@kitenet.net>2011-09-05 14:51:49 -0400
commit5cb0ecc00087d716a61dd42d7598a6fb78d60b7b (patch)
tree55c4fc8274c511d7bb32e44919f5224f4fcdaa9c /doc/bugs/cannot_revert_page_deletion.mdwn
parentbdcffa834acf82581972e482745cf6da50a20e18 (diff)
downloadikiwiki-5cb0ecc00087d716a61dd42d7598a6fb78d60b7b.tar
ikiwiki-5cb0ecc00087d716a61dd42d7598a6fb78d60b7b.tar.gz
Fix web revert of a file deletion.
When reverting, an add is a remove, and a remove is an add.
Diffstat (limited to 'doc/bugs/cannot_revert_page_deletion.mdwn')
-rw-r--r--doc/bugs/cannot_revert_page_deletion.mdwn8
1 files changed, 8 insertions, 0 deletions
diff --git a/doc/bugs/cannot_revert_page_deletion.mdwn b/doc/bugs/cannot_revert_page_deletion.mdwn
index 5292906a1..651b4d0ec 100644
--- a/doc/bugs/cannot_revert_page_deletion.mdwn
+++ b/doc/bugs/cannot_revert_page_deletion.mdwn
@@ -1,2 +1,10 @@
After deleting a page with the "remove" button, it seems that the page deletion cannot be reverted using the "revert" icon in [[RecentChanges]].
It ironically says that "Error: ?$pagename does not exist". See [[http://ikiwiki.info/ikiwiki.cgi?rev=860c2c84d98ea0a38a4f91dacef6d4e09f6e6c2e&do=revert]]. [[JeanPrivat]]
+
+> And it only gets that far if the remove plugin is enabled. Otherwise it
+> complains that you cannot change $pagename.
+>
+> The root bug is that git's `rcs_preprevert` creates a structure that
+> shows the change that was made (which includes a file deletion),
+> not the change that would be made if it was reverted (which includes a
+> file addition). [[Fixed|done]]. --[[Joey]]