aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs/bestlink_returns_deleted_pages.mdwn
diff options
context:
space:
mode:
authorJoey Hess <joey@gnu.kitenet.net>2009-11-30 18:06:04 -0500
committerJoey Hess <joey@gnu.kitenet.net>2009-11-30 18:08:54 -0500
commite104499f28f99408a6712aa603b9dd34e0b8471c (patch)
tree8ca574fbe770dde3e90a4c317e660526f2c88a33 /doc/bugs/bestlink_returns_deleted_pages.mdwn
parent01c0f533de4f6504df8e762125ec06f8458b1024 (diff)
downloadikiwiki-e104499f28f99408a6712aa603b9dd34e0b8471c.tar
ikiwiki-e104499f28f99408a6712aa603b9dd34e0b8471c.tar.gz
fixed.. partly
Diffstat (limited to 'doc/bugs/bestlink_returns_deleted_pages.mdwn')
-rw-r--r--doc/bugs/bestlink_returns_deleted_pages.mdwn14
1 files changed, 14 insertions, 0 deletions
diff --git a/doc/bugs/bestlink_returns_deleted_pages.mdwn b/doc/bugs/bestlink_returns_deleted_pages.mdwn
index 59e9dbcb5..035023c7d 100644
--- a/doc/bugs/bestlink_returns_deleted_pages.mdwn
+++ b/doc/bugs/bestlink_returns_deleted_pages.mdwn
@@ -13,6 +13,20 @@ However, find_del_files() does not remove the deleted page from %links (and %pag
Since find_del_files removes the deleted page from %pagesources and %destsources,
won't it make sense for bestlink() to check %pagesources first? --[[harishcm]]
+> This same problem turned out to also be the root of half of ikiwiki's
+> second-oldest bug, [[bestlink_change_update_issue]].
+>
+> Fixing it is really a bit involved, see commit
+> f1ddf4bd98821a597d8fa1532092f09d3d9b5483. The fix I committed fixes
+> bestlink to not return deleted pages, but only *after* the needsbuild and
+> scan hooks are called. So I was able to fix it for every case except the
+> one you gave! Sorry for that. To fix it during beedsbuild and scan,
+> a much more involved approach would be needed. AFAICS, no existing plugin
+> in ikiwiki uses bestlink in needsbuild or scan though.
+>
+> If the other half of [[bestlink_change_update_issue]] is fixed,
+> maybe by keeping a copy of the old backlinks info, then that fix could be
+> applied here too. --[[Joey]]
----