diff options
| author | Simon McVittie <smcv@debian.org> | 2017-01-09 13:58:58 +0000 |
|---|---|---|
| committer | Simon McVittie <smcv@debian.org> | 2017-01-09 13:58:58 +0000 |
| commit | 0463357392471f58ccd2c7f39cafabd8472e129b (patch) | |
| tree | a6fef77f47058291f648abb975a59c38382c4435 /IkiWiki | |
| parent | 59632384d963ec07b406d413df68079af794b56e (diff) | |
| download | ikiwiki-0463357392471f58ccd2c7f39cafabd8472e129b.tar ikiwiki-0463357392471f58ccd2c7f39cafabd8472e129b.tar.gz | |
git: don't redundantly pass "--" to git_sha1
git_sha1 already puts "--" before its arguments, so
git_sha1_file($dir, 'doc/index.mdwn')
would have incorrectly invoked
git rev-list --max-count=1 HEAD -- -- doc/index.mdwn
If there is no file in the wiki named "--", that's harmless, because
it merely names the latest revision in which either "--" or
"doc/index.mdwn" changed. However, it could return incorrect results
if there is somehow a file named "--".
Diffstat (limited to 'IkiWiki')
| -rw-r--r-- | IkiWiki/Plugin/git.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/IkiWiki/Plugin/git.pm b/IkiWiki/Plugin/git.pm index 23b99151e..2bc250052 100644 --- a/IkiWiki/Plugin/git.pm +++ b/IkiWiki/Plugin/git.pm @@ -578,7 +578,7 @@ sub rcs_find_changes ($) { sub git_sha1_file ($$) { my $dir=shift; my $file=shift; - return git_sha1($dir, "--", $file); + return git_sha1($dir, $file); } sub git_sha1 ($@) { |