* Add a test suite for the mercurial backend, contributed by Emanuele Aina.

* Add a test suite for the svn backend.
* Daemonize before sending RPC pings, since that can take a while
  and/or hang.
* Daemonize before sending commit mails, as that can also take a long
  time/hang if the mail server is unhappy.
* Factor out commit mail sending code into new function.

1 files changed, 55 insertions, 0 deletions

diff --git a/IkiWiki/UserInfo.pm b/IkiWiki/UserInfo.pm
index ae63d8023..34f05203a 100644
--- a/IkiWiki/UserInfo.pm
+++ b/IkiWiki/UserInfo.pm
@@ -108,4 +108,59 @@ sub commit_notify_list ($@) { #{{{
 	return @ret;
 } #}}}
 
+sub send_commit_mails ($$$@) { #{{{
+	my $messagesub=shift;
+	my $diffsub=shift;
+	my $user=shift;
+	my @changed_pages=shift;
+
+	my @email_recipients=commit_notify_list($user, @changed_pages);
+	if (@email_recipients) {
+		# TODO: if a commit spans multiple pages, this will send
+		# subscribers a diff that might contain pages they did not
+		# sign up for. Should separate the diff per page and
+		# reassemble into one mail with just the pages subscribed to.
+		my $diff=$diffsub->();
+		my $message=$messagesub->();
+
+		my $subject="update of $config{wikiname}'s ";
+		if (@changed_pages > 2) {
+			$subject.="$changed_pages[0] $changed_pages[1] etc";
+		}
+		else {
+			$subject.=join(" ", @changed_pages);
+		}
+		$subject.=" by $user";
+
+		my $template=template("notifymail.tmpl");
+		$template->param(
+			wikiname => $config{wikiname},
+			diff => $diff,
+			user => $user,
+			message => $message,
+		);
+
+		# Daemonize, in case the mail sending takes a while.
+		eval q{use POSIX ’setsid’};
+		chdir '/';
+		open STDIN, '/dev/null';
+		open STDOUT, '>/dev/null';
+		defined(my $pid = fork) or error("Can't fork: $!");
+		return if $pid;
+		setsid() or error("Can't start a new session: $!");
+		open STDERR, '>&STDOUT' or error("Can’t dup stdout: $!");
+
+		eval q{use Mail::Sendmail};
+		error($@) if $@;
+		foreach my $email (@email_recipients) {
+			sendmail(
+				To => $email,
+				From => "$config{wikiname} <$config{adminemail}>",
+				Subject => $subject,
+				Message => $template->output,
+			) or error("Failed to send update notification mail");
+		}
+	}
+} #}}}
+
 1