diff options
author | Joey Hess <joey@kodama.kitenet.net> | 2008-09-23 17:41:05 -0400 |
---|---|---|
committer | Joey Hess <joey@kodama.kitenet.net> | 2008-09-23 17:41:05 -0400 |
commit | 8e0180d8ca6c9b08ed752b92d4c50a5298d8f55a (patch) | |
tree | 6640c8959e194eb16f5cf36fdef1dc235e826706 /IkiWiki/Plugin/remove.pm | |
parent | dfa9556480e047704fbaa60616fdef7bf5ff2fc5 (diff) | |
download | ikiwiki-8e0180d8ca6c9b08ed752b92d4c50a5298d8f55a.tar ikiwiki-8e0180d8ca6c9b08ed752b92d4c50a5298d8f55a.tar.gz |
rename, remove: Don't rely on a form parameter to tell whether the page should be treated as an attachment.
Diffstat (limited to 'IkiWiki/Plugin/remove.pm')
-rw-r--r-- | IkiWiki/Plugin/remove.pm | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/IkiWiki/Plugin/remove.pm b/IkiWiki/Plugin/remove.pm index 9666408bc..869d32f93 100644 --- a/IkiWiki/Plugin/remove.pm +++ b/IkiWiki/Plugin/remove.pm @@ -21,11 +21,10 @@ sub getsetup () { #{{{ }, } #}}} -sub check_canremove ($$$$) { #{{{ +sub check_canremove ($$$) { #{{{ my $page=shift; my $q=shift; my $session=shift; - my $attachment=shift; # Must be a known source file. if (! exists $pagesources{$page}) { @@ -45,11 +44,15 @@ sub check_canremove ($$$$) { #{{{ # Must be editiable. IkiWiki::check_canedit($page, $q, $session); - # This is sorta overkill, but better safe - # than sorry. If a user can't upload an - # attachment, don't let them delete it. - if ($attachment) { - IkiWiki::Plugin::attachment::check_canattach($session, $page, $file); + # If a user can't upload an attachment, don't let them delete it. + # This is sorta overkill, but better safe than sorry. + if (! defined IkiWiki::pagetype($pagesources{$page})) { + if (IkiWiki::Plugin::attachment->can("check_canattach")) { + IkiWiki::Plugin::attachment::check_canattach($session, $page, $file); + } + else { + error("renaming of attachments is not allowed"); + } } } #}}} @@ -94,7 +97,7 @@ sub removal_confirm ($$@) { #{{{ my $attachment=shift; my @pages=@_; - check_canremove($_, $q, $session, $attachment) foreach @pages; + check_canremove($_, $q, $session) foreach @pages; # Save current form state to allow returning to it later # without losing any edits. @@ -167,7 +170,7 @@ sub sessioncgi ($$) { #{{{ # and that the user is allowed to edit(/remove) it. my @files; foreach my $page (@pages) { - check_canremove($page, $q, $session, $q->param("attachment")); + check_canremove($page, $q, $session); # This untaint is safe because of the # checks performed above, which verify the |