diff options
author | Simon McVittie <smcv@debian.org> | 2016-12-24 15:03:51 +0000 |
---|---|---|
committer | Simon McVittie <smcv@debian.org> | 2016-12-28 21:32:12 +0000 |
commit | c1120bbbe8fdea20cf64fa12247f4f4a4006c834 (patch) | |
tree | f25c576e39811b35933a043496f57dfdd6c67fb6 /IkiWiki/Plugin/linkmap.pm | |
parent | e193c75b7dd67cee731570c321a121cf79cb3c23 (diff) | |
download | ikiwiki-c1120bbbe8fdea20cf64fa12247f4f4a4006c834.tar ikiwiki-c1120bbbe8fdea20cf64fa12247f4f4a4006c834.tar.gz |
Force CGI::FormBuilder->field to scalar context where necessary
CGI::FormBuilder->field has behaviour similar to the CGI.pm misfeature
we avoided in f4ec7b0. Force it into scalar context where it is used
in an argument list.
This prevents two (relatively minor) commit metadata forgery
vulnerabilities:
* In the comments plugin, an attacker who was able to post a comment
could give it a user-specified author and author-URL even if the wiki
configuration did not allow for that, by crafting multiple values
to other fields.
* In the editpage plugin, an attacker who was able to edit a page
could potentially forge commit authorship by crafting multiple values
for the rcsinfo field.
The remaining plugins changed in this commit appear to have been
protected by use of explicit scalar prototypes for the called functions,
but have been changed anyway to make them more obviously correct.
In particular, checkpassword() in passwordauth has a known prototype,
so an attacker cannot trick it into treating multiple values of the
name field as being the username, password and field to check for.
OVE-20161226-0001
Diffstat (limited to 'IkiWiki/Plugin/linkmap.pm')
0 files changed, 0 insertions, 0 deletions