aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorhttps://www.google.com/accounts/o8/id?id=AItOawlqWSY9PNYRysA9vrU-JiQh7-s7q6SOcIE <Fergus@web>2012-04-23 17:14:31 -0400
committeradmin <admin@branchable.com>2012-04-23 17:14:31 -0400
commitd3dbb70fabe3cce3cda21a567eec62fc58f73ef5 (patch)
tree404a12ca14fd1dde3f9686fd817e3d7a07dc6436
parent9899aae804cce937958d38dfa5dd1a3fb39651e9 (diff)
downloadikiwiki-d3dbb70fabe3cce3cda21a567eec62fc58f73ef5.tar
ikiwiki-d3dbb70fabe3cce3cda21a567eec62fc58f73ef5.tar.gz
Respond to "proper patch" request from Joey (i.e. apology)
-rw-r--r--doc/todo/allow_TMPL__95__LOOP_in_template_directives.mdwn14
1 files changed, 14 insertions, 0 deletions
diff --git a/doc/todo/allow_TMPL__95__LOOP_in_template_directives.mdwn b/doc/todo/allow_TMPL__95__LOOP_in_template_directives.mdwn
index 6d0bd0971..890c4cf4b 100644
--- a/doc/todo/allow_TMPL__95__LOOP_in_template_directives.mdwn
+++ b/doc/todo/allow_TMPL__95__LOOP_in_template_directives.mdwn
@@ -14,6 +14,20 @@ rather limited way.
> the form of a patch that is reviewable, not a gratuitous rewrite.
> --[[Joey]]
+>> Yes, my apologies for that. The two worker functions `mktmpl_hash`
+and `proc_tmpl_hash` are new. The `preprocess` function then starts
+by arranging the parameters into an array. This array is passed to the
+`mktmpl_hash` and it creates a hash, suitable for passing into the
+HTML::Template directly. The `proc_tmpl_hash` then walks the hash
+structure and processes the parameters.
+
+>> I know ... you weren't looking for an explanation, just a patch
+... totally understand. Point I'm trying to make, it's a 90% re-write
+anyway (and my `style(8)` will probably piss most people off).
+
+>> Anyway, would love to contribute so will try to get to doing this
+"correctly" and post as a patch.
+
I would, personally, only use this feature for very basic loops
and, although nested loops *might* be possible (with a little
more tinkering) it think any attempt would be better served by