diff options
| author | Joey Hess <joeyh@joeyh.name> | 2019-01-21 11:44:29 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2019-01-21 11:44:29 -0400 |
| commit | 4cb6f48aff6645227dae5c7852d3122e4046142b (patch) | |
| tree | c4c1482b6a99466883b43034e1e244c0f6d6a9f7 | |
| parent | 22f3ca10723cbe4e4617b8dae2ee734f71dfa8e4 (diff) | |
| download | ikiwiki-4cb6f48aff6645227dae5c7852d3122e4046142b.tar ikiwiki-4cb6f48aff6645227dae5c7852d3122e4046142b.tar.gz | |
bug report
| -rw-r--r-- | doc/bugs/permalink_not_set_for_comments.mdwn | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/doc/bugs/permalink_not_set_for_comments.mdwn b/doc/bugs/permalink_not_set_for_comments.mdwn new file mode 100644 index 000000000..9ca8200b5 --- /dev/null +++ b/doc/bugs/permalink_not_set_for_comments.mdwn @@ -0,0 +1,16 @@ +Changes to comments result in notifyemail sending emails with broken urls like +"http://whatever/foo/comment_1_10a49d69282155c5c3e66dc58f64f956/" + +notifyemail uses meta permalink if set, so it must not be set for comment +pages. + +In the comments plugin, there's this code, which is supposed to set +permalink: + + if ($params{page} =~ m/\/\Q$config{comments_pagename}\E\d+_/) { + $pagestate{$page}{meta}{permalink} = urlto(IkiWiki::dirname($params{page})). + "#".page_to_id($params{page}); + } + +`comments_pagename` is `comment_` so the above code needs a comment page to contain +two underscores. I think that is the root of the bug. --[[Joey]] |