diff options
| author | Christopher Baines <mail@cbaines.net> | 2020-06-03 20:02:39 +0100 |
|---|---|---|
| committer | Christopher Baines <mail@cbaines.net> | 2020-06-03 20:02:39 +0100 |
| commit | 11b13edac90733d53c605125416a265f30474c0a (patch) | |
| tree | ccafa2b6930733327179a0e84204205796be2162 | |
| parent | 916b594473f2f776fbe745d77203df8152d57ee9 (diff) | |
| download | data-service-11b13edac90733d53c605125416a265f30474c0a.tar data-service-11b13edac90733d53c605125416a265f30474c0a.tar.gz | |
Populate package derivation outputs select options always
Even when the query parameters are invalid, as this is more useful. Thanks to
nckx for reporting.
| -rw-r--r-- | guix-data-service/web/revision/controller.scm | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/guix-data-service/web/revision/controller.scm b/guix-data-service/web/revision/controller.scm index f5ed8f0..d723c16 100644 --- a/guix-data-service/web/revision/controller.scm +++ b/guix-data-service/web/revision/controller.scm @@ -850,6 +850,9 @@ `("Revision " (samp ,commit-hash))) (header-link (string-append "/revision/" commit-hash))) + (define build-server-urls + (select-build-server-urls-by-id conn)) + (if (any-invalid-query-parameters? query-parameters) (case (most-appropriate-mime-type '(application/json text/html) @@ -863,9 +866,10 @@ commit-hash query-parameters '() - '() - '() - '() + build-server-urls + (valid-systems conn) + (valid-targets->options + (valid-targets conn)) #f #:path-base path-base #:header-text header-text @@ -889,8 +893,6 @@ #:target (assq-ref query-parameters 'target) #:limit-results limit-results #:after-path (assq-ref query-parameters 'after_path))) - (build-server-urls - (select-build-server-urls-by-id conn)) (show-next-page? (if all-results #f |