Expire database connection threads on exception

I'm concerned that SQLite is very sensitive to prepared statements being left
around without being finalized or reset, and I think this can happen if an
exception occurs in a worker, but before the reset or finalize happens.

Handling this in every individual case would be quite difficult, but given
that guile-sqlite finalizes prepared statements when you close a connection, I
think that mechanism can be used to somewhat rigerously avoid this (at least
for cached prepared statements).

1 files changed, 2 insertions, 0 deletions

diff --git a/guix-build-coordinator/datastore/sqlite.scm b/guix-build-coordinator/datastore/sqlite.scm
index bcac7e6..90fd3b6 100644
--- a/guix-build-coordinator/datastore/sqlite.scm
+++ b/guix-build-coordinator/datastore/sqlite.scm
@@ -171,6 +171,7 @@ CREATE TABLE IF NOT EXISTS mem.build_allocation_plan (
           (metric-increment writer-thread-destructor-counter)
           (sqlite-close db)))
       #:lifetime 500
+      #:expire-on-exception? #t
 
       ;; SQLite doesn't support parallel writes
       #:parallelism 1
@@ -220,6 +221,7 @@ CREATE TABLE IF NOT EXISTS mem.build_allocation_plan (
           (metric-increment reader-thread-destructor-counter)
           (sqlite-close db)))
       #:lifetime 50000
+      #:expire-on-exception? #t
 
       ;; Use a minimum of 2 and a maximum of 8 threads
       #:parallelism