| Commit message (Expand) | Author | Age |
|---|
| * | Merge remote branch 'origin/maint-0.2.2' | Nick Mathewson | 2010-10-21 |
| |\ |
|
| | * | Send relay_early cells in rend circs•••There are no relay left that run version 0.2.1.3 through 0.2.1.18, so
changing this behaviour should be safe now.
| Sebastian Hahn | 2010-10-18 |
| * | | Merge branch 'bug1992_part1' | Nick Mathewson | 2010-10-15 |
| |\ \ |
|
| | * | | refactor all these tor_inet_ntoa idioms•••but don't refactor the ones that look messy
| Roger Dingledine | 2010-10-01 |
| * | | | Fix a couple users of buf_datalen that slipped in. Found by Sebastian | Nick Mathewson | 2010-10-13 |
| * | | | Initial conversion to use node_t throughout our codebase.•••A node_t is an abstraction over routerstatus_t, routerinfo_t, and
microdesc_t. It should try to present a consistent interface to all
of them. There should be a node_t for a server whenever there is
* A routerinfo_t for it in the routerlist
* A routerstatus_t in the current_consensus.
(note that a microdesc_t alone isn't enough to make a node_t exist,
since microdescriptors aren't usable on their own.)
There are three ways to get a node_t right now: looking it up by ID,
looking it up by nickname, and iterating over the whole list of
microdescriptors.
All (or nearly all) functions that are supposed to return "a router"
-- especially those used in building connections and circuits --
should return a node_t, not a routerinfo_t or a routerstatus_t.
A node_t should hold all the *mutable* flags about a node. This
patch moves the is_foo flags from routerinfo_t into node_t. The
flags in routerstatus_t remain, but they get set from the consensus
and should not change.
Some other highlights of this patch are:
* Looking up routerinfo and routerstatus by nickname is now
unified and based on the "look up a node by nickname" function.
This tries to look only at the values from current consensus,
and not get confused by the routerinfo_t->is_named flag, which
could get set for other weird reasons. This changes the
behavior of how authorities (when acting as clients) deal with
nodes that have been listed by nickname.
* I tried not to artificially increase the size of the diff here
by moving functions around. As a result, some functions that
now operate on nodes are now in the wrong file -- they should
get moved to nodelist.c once this refactoring settles down.
This moving should happen as part of a patch that moves
functions AND NOTHING ELSE.
* Some old code is now left around inside #if 0/1 blocks, and
should get removed once I've verified that I don't want it
sitting around to see how we used to do things.
There are still some unimplemented functions: these are flagged
with "UNIMPLEMENTED_NODELIST()." I'll work on filling in the
implementation here, piece by piece.
I wish this patch could have been smaller, but there did not seem to
be any piece of it that was independent from the rest. Moving flags
forces many functions that once returned routerinfo_t * to return
node_t *, which forces their friends to change, and so on.
| Nick Mathewson | 2010-10-01 |
| * | | | Try to make most routerinfo_t interfaces const | Nick Mathewson | 2010-10-01 |
| |/ / |
|
| * | | Make a function to mark a connection and set hold_open_until_flushed. | Nick Mathewson | 2010-09-27 |
| * | | Refactor users of buf_datalen to bufferevent-friendly version. | Nick Mathewson | 2010-09-27 |
| * | | Teach read_event/write_event manipulators about bufferevents.•••Add an --enable-bufferevents config switch.
| Nick Mathewson | 2010-09-27 |
| |/ |
|
| * | I hear we are close to a release. Clean up the whitespace. | Nick Mathewson | 2010-09-16 |
| * | Demote a warn when enabling CellStatistics•••When the CellStatistics option is off, we don't store cell insertion
times. Doing so would also not be very smart, because there seem to
still be some performance issues with this type of statistics. Nothing
harmful happens when we don't have insertion times, so we don't need to
alarm the user.
| Sebastian Hahn | 2010-09-16 |
| * | Merge branch 'bug1184' | Nick Mathewson | 2010-09-15 |
| |\ |
|
| | * | Never queue a cell on a marked circuit | Nick Mathewson | 2010-09-15 |
| | * | Clear cell queues when marking or truncating a circuit.•••At best, this patch helps us avoid sending queued relayed cells that
would get ignored during the time between when a destroy cell is
sent and when the circuit is finally freed. At worst, it lets us
release some memory a little earlier than it would otherwise.
Fix for bug #1184. Bugfix on 0.2.0.1-alpha.
| Nick Mathewson | 2010-07-30 |
| * | | Add a simple integer-ceiling-division macro before we get it wrong | Nick Mathewson | 2010-09-14 |
| * | | Make circuit_resume_edge_reading_helper treat streams more fairly.•••Previously[*], the function would start with the first stream on the
circuit, and let it package as many cells as it wanted before
proceeding to the next stream in turn. If a circuit had many live
streams that all wanted to package data, the oldest would get
preference, and the newest would get ignored.
Now, we figure out how many cells we're willing to send per stream,
and try to allocate them fairly.
Roger diagnosed this in the comments for bug 1298.
[*] This bug has existed since before the first-ever public release
of Tor. It was added by r152 of Tor on 26 Jan 2003, which was
the first commit to implement streams (then called "topics").
This is not the oldest bug to be fixed in 0.2.2.x: that honor
goes to the windowing bug in r54, which got fixed in e50b7768 by
Roger with diagnosis by Karsten. This is, however, the most
long-lived bug to be fixed in 0.2.2.x: the r54 bug was fixed
2580 days after it was introduced, whereas I am writing this
commit message 2787 days after r152.
| Nick Mathewson | 2010-09-13 |
| * | | Add a max_cells arg to connection_edge_process_raw_inbuf•••I'm going to use this to implement more fairness in
circuit_resume_edge_reading_helper in an attempt to fix bug 1298.
(Updated with fixes from arma and Sebastian)
| Nick Mathewson | 2010-09-13 |
| * | | Fix function declaration linebreaks at start of relay.c | Nick Mathewson | 2010-09-13 |
| * | | be more consistent in using streamid_t | Nick Mathewson | 2010-09-08 |
| * | | Fix a missing stream_id argument; found by "tracktor" | Nick Mathewson | 2010-09-03 |
| * | | Fix behavior of adding a cell to a blocked queue.•••We frequently add cells to stream-blocked queues for valid reasons
that don't mean we need to block streams. The most obvious reason
is if the cell arrives over a circuit rather than from an edge: we
don't block circuits, no matter how full queues get. The next most
obvious reason is that we allow CONNECTED cells from a newly created
stream to get delivered just fine.
This patch changes the behavior so that we only iterate over the
streams on a circuit when the cell in question came from a stream,
and we only block the stream that generated the cell, so that other
streams can still get their CONNECTEDs in.
| Nick Mathewson | 2010-09-02 |
| * | | Detect if we try to put a cell onto a supposedly blocked cell queue.•••When this happens, run through the streams on the circuit and make
sure they're all blocked. If some aren't, that's a bug: block them
all and log it! If they all are, where did the cell come from? Log
it!
(I suspect that this actually happens pretty frequently, so I'm making
these log messages appear at INFO.)
| Nick Mathewson | 2010-08-18 |
| * | | Decide whether to ignore SENDMEs based on streams_blocked, not queue size | Nick Mathewson | 2010-08-18 |
| * | | Avoid over-filling cell queues when we receive a SENDME•••Do not start reading on exit streams when we get a SENDME unless we
have space in the appropriate circuit's cell queue.
Draft fix for bug 1653.
(commit message by nickm)
| yetonetime | 2010-08-18 |
| * | | 161b2750 didn't really retry the stream. this does. | Roger Dingledine | 2010-08-16 |
| * | | Merge commit 'sebastian/bug1831' | Nick Mathewson | 2010-08-15 |
| |\ \ |
|
| | * | | Fix misplaced labels | Sebastian Hahn | 2010-08-16 |
| | |/ |
|
| * | | Merge commit 'sebastian/misc-reason' | Nick Mathewson | 2010-08-15 |
| |\ \
| |/
|/| |
|
| | * | Retry streams that ended with NOROUTE error•••Also add the NOROUTE reason to control-spec.
| Sebastian Hahn | 2010-08-04 |
| * | | Create routerparse.h | Sebastian Hahn | 2010-07-27 |
| * | | Create relay.h | Sebastian Hahn | 2010-07-27 |
| * | | Create reasons.h | Sebastian Hahn | 2010-07-27 |
| * | | Create policies.h | Sebastian Hahn | 2010-07-27 |
| * | | Create networkstatus.h | Sebastian Hahn | 2010-07-27 |
| * | | Create main.h | Sebastian Hahn | 2010-07-27 |
| * | | Create control.h | Sebastian Hahn | 2010-07-27 |
| * | | Create connection_or.h | Sebastian Hahn | 2010-07-27 |
| * | | Create connection_edge.h | Sebastian Hahn | 2010-07-27 |
| * | | Create connection.h | Sebastian Hahn | 2010-07-27 |
| * | | Create config.h | Sebastian Hahn | 2010-07-27 |
| * | | Create circuitlist.h | Sebastian Hahn | 2010-07-27 |
| * | | Create circuitbuild.h | Sebastian Hahn | 2010-07-27 |
| * | | Create buffers.h | Sebastian Hahn | 2010-07-27 |
| * | | Create rendcommon.h | Sebastian Hahn | 2010-07-27 |
| * | | Create routerlist.h | Sebastian Hahn | 2010-07-27 |
| * | | Create geoip.h | Sebastian Hahn | 2010-07-27 |
| * | | Rename CircPriorityHalflifeMsec to CircuitPriorityHalflifeMsec•••Everything that accepted the 'Circ' name handled it wrong, so even now
that we fixed the handling of the parameter, we wouldn't be able to
set it without making all the 0.2.2.7..0.2.2.10 relays act wonky.
This patch makes Tors accept the 'Circuit' name instead, so we can
turn on circuit priorities without confusing the versions that treated
the 'Circ' name as occasion to act weird.
| Nick Mathewson | 2010-04-13 |
| * | | Fix a bug in reading CircPriorityHalflife from consensus•••When you mean (a=b(c,d)) >= 0, you had better not say (a=b(c,d)>=0).
We did the latter, and so whenever CircPriorityHalflife was in the
consensus, it was treated as having a value of 1 msec (that is,
boolean true).
| Nick Mathewson | 2010-04-12 |
| * | | Merge remote branch 'origin/maint-0.2.1'•••Conflicts:
src/common/test.h
src/or/test.c
| Nick Mathewson | 2010-02-27 |
| |\| |
|