| Commit message (Expand) | Author | Age |
* | Fix compile warning in tor_inet_pton() (on 64bit)•••This slipped through into 0.2.3.8-alpha unfortunately.
| Sebastian Hahn | 2011-11-24 |
* | Merge remote-tracking branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-11-23 |
|\ |
|
| * | Merge remote-tracking branch 'public/bug4230' into maint-0.2.2 | Nick Mathewson | 2011-11-23 |
| |\ |
|
| | * | Correct the handling of overflow behavior in smartlist_ensure_capacity•••The old behavior was susceptible to the compiler optimizing out our
assertion check, *and* could still overflow size_t on 32-bit systems
even when it did work.
| Nick Mathewson | 2011-11-09 |
| * | | Sockets are unsigned on windows•••this gets rid of a warning about signed/unsigned comparison
This is a backport of 0a5338e03cdf14ef80584c6ff8adeb49200b8a76 that
accidentally only went into master
| Sebastian Hahn | 2011-11-20 |
| * | | Get rid of an unused parameter warning on win•••This is a backport of bed79c47f4ec0ee72b19e2b81c54131d516d07ef which
accidentally only went into master
| Sebastian Hahn | 2011-11-20 |
* | | | Minor tor_inet_pton bug fixes•••In particular:
* Disallow "0x10::"
* Don't blow up on ":"
* Disallow "::10000"
| Anders Sundman | 2011-11-19 |
* | | | Merge branch 'bug4457_master' | Nick Mathewson | 2011-11-16 |
|\ \ \ |
|
| * | | | Disable IOCP and retry event_base_new_with_config once on failure•••This is a fancier bug4457 workaround for 0.2.3. In 0.2.2, we could
just tell Libevent "Don't enable locking!" so it wouldn't try to make
the event_base notifiable. But for IOCP, we need a notifiable base.
(Eventually, we'll want a notifiable base for other stuff, like
multithreaded crypto.) So the solution is to try a full-featured
initialization, and then retry with all the options turned off if that
fails.
| Nick Mathewson | 2011-11-14 |
| * | | | Merge remote-tracking branch 'public/bug4457_022' into bug4457_master•••Conflicts:
src/common/compat_libevent.c
Resolving conflict by not taking 7363eae13cb8 ("Use the
EVENT_BASE_FLAG_NOLOCK flag to prevent socketpair() invocation"): in
Tor 0.2.3.x, we _do_ sometimes use notifiable event bases.
| Nick Mathewson | 2011-11-14 |
| |\| | |
|
| | * | | Detect failure from event_init() or event_base_new_with_config() | Nick Mathewson | 2011-11-14 |
| | * | | Use the EVENT_BASE_FLAG_NOLOCK flag to prevent socketpair() invocation•••In Tor 0.2.2, we never need the event base to be notifiable, since we
don't call it from other threads. This is a workaround for bug 4457,
which is not actually a Tor bug IMO.
| Nick Mathewson | 2011-11-14 |
* | | | | Fix a check-spaces complaint | Sebastian Hahn | 2011-11-16 |
* | | | | Don't allow building on platforms where AF_UNSPEC != 0 | Sebastian Hahn | 2011-11-16 |
* | | | | Make certificate skew into a protocol warning | Nick Mathewson | 2011-11-15 |
* | | | | Allow up to a 30 days future skew, 48 hours past skew in certs. | Nick Mathewson | 2011-11-15 |
* | | | | Fix compile warnings on windows | Sebastian Hahn | 2011-11-15 |
|/ / / |
|
* | | | Merge remote-tracking branch '4ZM/topic/test/4433_address' | Nick Mathewson | 2011-11-14 |
|\ \ \ |
|
| * | | | Return value bugfix of tor_addr_to_PTR_name•••Returns value semantics was inconsitent between IPv4 and IPv6
| Anders Sundman | 2011-11-11 |
* | | | | Remove the torint.h include from aes.h•••This hasn't been needed for a while, there's nothing in aes.h now that
would need uint* stuff.
| Sebastian Hahn | 2011-11-11 |
* | | | | Remove vestiges of RIJNDAEL_COUNTER_OPTIMIZATION | Nick Mathewson | 2011-11-11 |
* | | | | Stop using "u32" and "u8" in aes.c | Nick Mathewson | 2011-11-11 |
* | | | | Dump our internal AES implementation•••This thing was pretty pointless on versions of OpenSSL 0.9.8 and later,
and almost totally pointless on OpenSSL 1.0.0.
Also, favor EVP by default, since it lets us get hardware acceleration
where present. (See issue 4442)
| Nick Mathewson | 2011-11-11 |
* | | | | Fixed buffer bounds check bug in tor_addr_to_str | Anders Sundman | 2011-11-11 |
* | | | | Fixed of-by-one error in tor_inet_ntop•••The of-by-one error could lead to 1 byte buffer over runs IPv6 for addresses.
| Anders Sundman | 2011-11-11 |
|/ / / |
|
* | | | Merge remote-tracking branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-11-09 |
|\| | |
|
| * | | Don't warn when compiling with --disable-threads•••STMT_VOID semantics suggested by nick, thanks!
| Sebastian Hahn | 2011-11-09 |
* | | | Remove some duplicate includes | Andrea Gelmini | 2011-11-03 |
* | | | Fix a memory-poisoning memset in tortls.c | Nick Mathewson | 2011-10-28 |
* | | | Merge branch 'maint-0.2.2_secfix' into master_secfix•••Conflicts:
src/common/tortls.c
src/or/connection_or.c
src/or/dirserv.c
src/or/or.h
| Sebastian Hahn | 2011-10-27 |
|\| | |
|
| * | | Merge branch 'maint-0.2.1_secfix' into maint-0.2.2_secfix•••Conflicts:
src/or/connection_or.c
| Sebastian Hahn | 2011-10-26 |
| |\| |
|
| | * | Don't send a certificate chain on outgoing TLS connections from non-relays | Nick Mathewson | 2011-10-26 |
| | * | Properly refcount client_identity_key•••In a2bb0bf we started using a separate client identity key. When we are
in "public server mode" (that means not a bridge) we will use the same
key. Reusing the key without doing the proper refcounting leads to a
segfault on cleanup during shutdown. Fix that.
Also introduce an assert that triggers if our refcount falls below 0.
That should never happen.
| Sebastian Hahn | 2011-10-26 |
| | * | Make crypto_free_pk_env tolerate NULL arg in 0.2.1. Error-proofing against b... | Nick Mathewson | 2011-10-26 |
| | * | Maintain separate server and client TLS contexts.•••Fixes bug #988.
Conflicts:
src/or/main.c
src/or/router.c
| Robert Ransom | 2011-10-26 |
| | * | Refactor tor_tls_context_new:•••* Make tor_tls_context_new internal to tortls.c, and return the new
tor_tls_context_t from it.
* Add a public tor_tls_context_init wrapper function to replace it.
Conflicts:
src/or/main.c
src/or/router.c
| Robert Ransom | 2011-10-26 |
| | * | Fix zlib macro brokenness on osx with zlib 1.2.4 and higher.•••From the code:
zlib 1.2.4 and 1.2.5 do some "clever" things with macros. Instead of
saying "(defined(FOO) ? FOO : 0)" they like to say "FOO-0", on the theory
that nobody will care if the compile outputs a no-such-identifier warning.
Sorry, but we like -Werror over here, so I guess we need to define these.
I hope that zlib 1.2.6 doesn't break these too.
Possible fix for bug 1526.
| Nick Mathewson | 2011-10-26 |
* | | | Merge remote-tracking branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-10-26 |
|\| | |
|
| * | | Make internal error check for unrecognized digest algorithm more robust•••Fixes Coverity CID 479.
| Nick Mathewson | 2011-10-06 |
* | | | Fix a reference-leak in tor_tls_received_v3_certificate•••We were calling SSL_get_peer_certificate but not X509_free.
This is a major part of bug4252; the bug has been in no released version.
| Nick Mathewson | 2011-10-23 |
* | | | Fix memory leak in prop176 code•••This fixes part of bug4252. Bug not in any released version.
| Nick Mathewson | 2011-10-23 |
* | | | Stop using addr_port_lookup as an address splitting function•••It's too risky to have a function where if you leave one parameter
NULL, it splits up address:port strings, but if you set it, it does
hostname resolution.
| Nick Mathewson | 2011-10-11 |
* | | | Change "reverse_lookup_name" functions to refer to "PTR_name"s•••Under the new convention, having a tor_addr.*lookup function that
doesn't do hostname resolution is too close for comfort.
I used this script here, and have made no other changes.
s/tor_addr_parse_reverse_lookup_name/tor_addr_parse_PTR_name/g;
s/tor_addr_to_reverse_lookup_name/tor_addr_to_PTR_name/g;
| Nick Mathewson | 2011-10-11 |
* | | | Fix names of functions that convert strings to addrs•••Now let's have "lookup" indicate that there can be a hostname
resolution, and "parse" indicate that there wasn't. Previously, we
had one "lookup" function that did resolution; four "parse" functions,
half of which did resolution; and a "from_str()" function that didn't
do resolution. That's confusing and error-prone!
The code changes in this commit are exactly the result of this perl
script, run under "perl -p -i.bak" :
s/tor_addr_port_parse/tor_addr_port_lookup/g;
s/parse_addr_port(?=[^_])/addr_port_lookup/g;
s/tor_addr_from_str/tor_addr_parse/g;
This patch leaves aton and pton alone: their naming convention and
behavior is is determined by the sockets API.
More renaming may be needed.
| Nick Mathewson | 2011-10-11 |
* | | | Fix a bunch of whitespace errors | Nick Mathewson | 2011-10-11 |
* | | | Add some points to make it easy to turn off v3 support | Nick Mathewson | 2011-10-10 |
* | | | Quiet two notices, and spelling mistake cleanup | Sebastian Hahn | 2011-10-10 |
* | | | Give tor_cert_get_id_digests() fail-fast behavior•••Right now we can take the digests only of an RSA key, and only expect to
take the digests of an RSA key. The old tor_cert_get_id_digests() would
return a good set of digests for an RSA key, and an all-zero one for a
non-RSA key. This behavior is too error-prone: it carries the risk that
we will someday check two non-RSA keys for equality and conclude that
they must be equal because they both have the same (zero) "digest".
Instead, let's have tor_cert_get_id_digests() return NULL for keys we
can't handle, and make its callers explicitly test for NULL.
| Nick Mathewson | 2011-10-10 |
* | | | Fix some more issues wrt tor_cert_new found by asn | Nick Mathewson | 2011-10-10 |
* | | | Generate certificates that enable v3 handshake | Nick Mathewson | 2011-10-10 |