| Commit message (Expand) | Author | Age |
* | Merge remote-tracking branch 'public/3122_memcmp_squashed' into bug3122_memcm...•••Conflicts throughout. All resolved in favor of taking HEAD and
adding tor_mem* or fast_mem* ops as appropriate.
src/common/Makefile.am
src/or/circuitbuild.c
src/or/directory.c
src/or/dirserv.c
src/or/dirvote.c
src/or/networkstatus.c
src/or/rendclient.c
src/or/rendservice.c
src/or/router.c
src/or/routerlist.c
src/or/routerparse.c
src/or/test.c
| Nick Mathewson | 2011-05-11 |
|\ |
|
| * | Hand-conversion and audit phase of memcmp transition•••Here I looked at the results of the automated conversion and cleaned
them up as follows:
If there was a tor_memcmp or tor_memeq that was in fact "safe"[*] I
changed it to a fast_memcmp or fast_memeq.
Otherwise if there was a tor_memcmp that could turn into a
tor_memneq or tor_memeq, I converted it.
This wants close attention.
[*] I'm erring on the side of caution here, and leaving some things
as tor_memcmp that could in my opinion use the data-dependent
fast_memcmp variant.
| Nick Mathewson | 2011-05-11 |
| * | Automated conversion of memcmp to tor_memcmp/tor_mem[n]eq•••This commit is _exactly_ the result of
perl -i -pe 's/\bmemcmp\(/tor_memcmp\(/g' src/*/*.[ch]
perl -i -pe 's/\!\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch]
perl -i -pe 's/0\s*==\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch]
perl -i -pe 's/0\s*!=\s*tor_memcmp\(/tor_memneq\(/g' src/*/*.[ch]
git checkout src/common/di_ops.[ch]
git checkout src/or/test.c
git checkout src/common/test.h
| Nick Mathewson | 2011-05-11 |
* | | Doxygen documentation for about 100 things that didn't have any•••About 860 doxygen-less things remain in 0.2.2
| Nick Mathewson | 2011-03-16 |
* | | Merge remote branch 'origin/maint-0.2.1' into maint-0.2.2 | Nick Mathewson | 2011-01-15 |
|\| |
|
| * | clean up message; explain a magic number in a comment | Nick Mathewson | 2011-01-15 |
| * | Fix a SIZE_T_CEILING check in torgzip.c; noticed by cypherpunks | Nick Mathewson | 2011-01-05 |
| * | Detect and disallow compression bombs | Nick Mathewson | 2011-01-03 |
* | | Merge remote branch 'origin/maint-0.2.1' into maint-0.2.2•••Conflicts:
src/common/test.h
src/or/test.c
| Nick Mathewson | 2011-01-03 |
|\| |
|
| * | Bump copyright statements to 2011 | Nick Mathewson | 2011-01-03 |
* | | Rename log.h to torlog.h•••This should make us conflict less with system files named "log.h".
Yes, we shouldn't have been conflicting with those anyway, but some
people's compilers act very oddly.
The actual change was done with one "git mv", by editing
Makefile.am, and running
find . -name '*.[ch]' | xargs perl -i -pe 'if (/^#include.*\Wlog.h/) {s/log.h/torlog.h/; }'
| Nick Mathewson | 2010-07-09 |
* | | Merge branch 'bug1526-v2' | Nick Mathewson | 2010-06-25 |
|\ \ |
|
| * | | Fix zlib macro brokenness on osx with zlib 1.2.4 and higher.•••From the code:
zlib 1.2.4 and 1.2.5 do some "clever" things with macros. Instead of
saying "(defined(FOO) ? FOO : 0)" they like to say "FOO-0", on the theory
that nobody will care if the compile outputs a no-such-identifier warning.
Sorry, but we like -Werror over here, so I guess we need to define these.
I hope that zlib 1.2.6 doesn't break these too.
Possible fix for bug 1526.
| Nick Mathewson | 2010-06-22 |
| |/ |
|
* | | Merge remote branch 'origin/maint-0.2.1'•••Conflicts:
src/common/test.h
src/or/test.c
| Nick Mathewson | 2010-02-27 |
|\| |
|
| * | Update Tor Project copyright years | Nick Mathewson | 2010-02-27 |
* | | Now that FOO_free(NULL) always works, remove checks before calling it. | Nick Mathewson | 2009-12-12 |
* | | *_free functions now accept NULL•••Some *_free functions threw asserts when passed NULL. Now all of them
accept NULL as input and perform no action when called that way.
This gains us consistence for our free functions, and allows some
code simplifications where an explicit null check is no longer necessary.
| Sebastian Hahn | 2009-12-12 |
|/ |
|
* | Spelling fixes in comments and strings | Nick Mathewson | 2009-05-27 |
* | Update copyright to 2009. | Karsten Loesing | 2009-05-04 |
* | Fix up (I hope) most ot the things that coverity suddenly claimed were REVERS...•••svn:r18096
| Nick Mathewson | 2009-01-13 |
* | Another fun openbsd warning fix. On ioerror's computer at least, they redefi...•••svn:r17892
| Nick Mathewson | 2009-01-04 |
* | Remove svn $Id$s from our source, and remove tor --version --version.•••The subversion $Id$ fields made every commit force a rebuild of
whatever file got committed. They were not actually useful for
telling the version of Tor files in the wild.
svn:r17867
| Nick Mathewson | 2009-01-04 |
* | r14374@tombo: nickm | 2008-02-21 16:57:39 -0500••• Fix all remaining shorten-64-to-32 errors in src/common. Some were genuine problems. Many were compatibility errors with libraries (openssl, zlib) that like predate size_t. Partial backport candidate.
svn:r13665
| Nick Mathewson | 2008-02-21 |
* | r18208@catbus: nickm | 2008-02-19 17:02:30 -0500••• Add some checks in torgzip.c to make sure we never overflow size_t there. Also make sure we do not realloc(list,0) in container.c. Backport candidate.
svn:r13587
| Nick Mathewson | 2008-02-19 |
* | Update some copyright notices: it is now 2008.•••svn:r13412
| Nick Mathewson | 2008-02-07 |
* | r17639@catbus: nickm | 2008-01-15 19:09:21 -0500••• Fix some hard to trigger but nonetheless real memory leaks spotted by an anonymous contributor. Needs review. Partial backport candidate.
svn:r13147
| Nick Mathewson | 2008-01-16 |
* | clean up copyrights, and assign 2007 copyrights to The Tor Project, Inc•••svn:r12786
| Roger Dingledine | 2007-12-12 |
* | r13858@catbus: nickm | 2007-07-22 18:44:02 -0400••• Fix/note some relatively trivial mem usage issues
svn:r10905
| Nick Mathewson | 2007-07-22 |
* | doc pedant•••svn:r9634
| Roger Dingledine | 2007-02-24 |
* | r11826@catbus: nickm | 2007-02-16 14:58:38 -0500••• Resolve 56 DOCDOC comments.
svn:r9594
| Nick Mathewson | 2007-02-16 |
* | r11775@catbus: nickm | 2007-02-12 16:39:09 -0500••• Update copyright dates.
svn:r9570
| Nick Mathewson | 2007-02-12 |
* | r11629@catbus: nickm | 2007-02-02 15:06:17 -0500••• Removing the last DOCDOC comment hurt so much that I had to use Doxygen to identify undocumented macros and comments, and add 150 more DOCDOCs to point out where they were. Oops. Hey, kids! Fixing some of these could be your first Tor patch!
svn:r9477
| Nick Mathewson | 2007-02-02 |
* | r9313@totoro: nickm | 2006-11-13 20:07:41 -0500••• Try to compile with fewer warnings on irix64's MIPSpro compiler /
environment, which apparently believes that:
- off_t can be bigger than size_t.
- only mean kids assign things they do not subsequently inspect.
I don't try to fix the "error" that makes it say:
cc-3970 cc: WARNING File = main.c, Line = 1277
conversion from pointer to same-sized integral type (potential portability
problem)
uintptr_t sig = (uintptr_t)arg;
Because really, what can you do about a compiler that claims to be c99
but doesn't understand that void* x = NULL; uintptr_t y = (uintptr_t) x;
is safe?
svn:r8948
| Nick Mathewson | 2006-11-14 |
* | r8957@totoro: nickm | 2006-10-08 22:35:17 -0400••• The otherwise regrettable MIPSpro C compiler warns about values set but never used, and about mixing enums and ints; these are good warnings, and so should be fixed. This removes some dead code and some potential bugs. Thanks to pnx.
svn:r8664
| Nick Mathewson | 2006-10-09 |
* | r9032@Kushana: nickm | 2006-09-29 18:51:42 -0400••• Now, all log messages should be distinct.
svn:r8545
| Nick Mathewson | 2006-09-29 |
* | r9023@Kushana: nickm | 2006-09-29 17:27:24 -0400••• Make distinct all non-bug messages at notice or higher that appear 3 or more times.
svn:r8541
| Nick Mathewson | 2006-09-29 |
* | r9008@Kushana: nickm | 2006-09-29 13:50:10 -0400••• Doxygen comments for code in common. Also simplify a few code paths to be more clear/speedy/correct.
svn:r8536
| Nick Mathewson | 2006-09-29 |
* | Harmless: Z_OK is not an acceptable answer to Z_FINISH.•••svn:r6701
| Nick Mathewson | 2006-06-29 |
* | Apparently, zlib sometimes reports Z_BUF_ERROR on input exhaustion as well as...•••svn:r6682
| Nick Mathewson | 2006-06-24 |
* | Add some incremental encryption wrappers to torgzip code•••svn:r6636
| Nick Mathewson | 2006-06-18 |
* | Patch based on post by Mike C to or-dev; special-case based on use of MSVC, r...•••svn:r6523
| Nick Mathewson | 2006-06-03 |
* | Fix memory leak when uncompressing concatenated zlib streams. Unit tests and ...•••svn:r6211
| Nick Mathewson | 2006-03-21 |
* | ok, commenting that out broke things real bad.•••leave it, and accept the memory leak for now.
svn:r6201
| Roger Dingledine | 2006-03-20 |
* | Resolve a memory leak on clients. This disables some•••functionality that we might still want. Nick?
svn:r6200
| Roger Dingledine | 2006-03-20 |
* | Start the process of converting warn to log_warn and so on.•••This is needed because Windows already has an err() that we
can't clobber. And we need to be able to make the log functions
a macro so we can print the function's name in the log entry.
svn:r6000
| Roger Dingledine | 2006-02-13 |
* | and don't warn when it happens here either, unless the user•••wants to hear it.
svn:r5990
| Roger Dingledine | 2006-02-12 |
* | Correct a function comment. Nick: is this right?•••svn:r5989
| Roger Dingledine | 2006-02-12 |
* | Happy new year!•••svn:r5949
| Roger Dingledine | 2006-02-09 |
* | Bite the bullet and limit all our source lines to 80 characters, the way IBM ...•••svn:r5582
| Nick Mathewson | 2005-12-14 |
* | Start dividing log messages into logging domains. No, LD_ is not the best of...•••svn:r5284
| Nick Mathewson | 2005-10-18 |