aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--changes/bug104854
-rw-r--r--src/or/main.c5
-rw-r--r--src/or/rephist.c2
-rw-r--r--src/or/status.c6
4 files changed, 11 insertions, 6 deletions
diff --git a/changes/bug10485 b/changes/bug10485
new file mode 100644
index 000000000..aa599fba7
--- /dev/null
+++ b/changes/bug10485
@@ -0,0 +1,4 @@
+ o Minor bugfixes:
+ - Turn "circuit handshake stats since last time" log messages into a
+ heartbeat message. Fixes bug 10485; bugfix on 0.2.4.17-rc.
+
diff --git a/src/or/main.c b/src/or/main.c
index e14001f10..dd4214ef0 100644
--- a/src/or/main.c
+++ b/src/or/main.c
@@ -1373,11 +1373,6 @@ run_scheduled_events(time_t now)
next_time_to_write_stats_files = next_write;
}
time_to_write_stats_files = next_time_to_write_stats_files;
-
- /* Also commandeer this opportunity to log how our circuit handshake
- * stats have been doing. */
- if (public_server_mode(options))
- rep_hist_log_circuit_handshake_stats(now);
}
/* 1h. Check whether we should write bridge statistics to disk.
diff --git a/src/or/rephist.c b/src/or/rephist.c
index 13404badf..dd4ef12ef 100644
--- a/src/or/rephist.c
+++ b/src/or/rephist.c
@@ -3018,7 +3018,7 @@ rep_hist_log_circuit_handshake_stats(time_t now)
{
(void)now;
/* XXX024 maybe quiet this log message before 0.2.4 goes stable for real */
- log_notice(LD_HIST, "Circuit handshake stats since last time: "
+ log_notice(LD_HEARTBEAT, "Circuit handshake stats since last time: "
"%d/%d TAP, %d/%d NTor.",
onion_handshakes_completed[ONION_HANDSHAKE_TYPE_TAP],
onion_handshakes_requested[ONION_HANDSHAKE_TYPE_TAP],
diff --git a/src/or/status.c b/src/or/status.c
index 6e2206e5e..415f4daea 100644
--- a/src/or/status.c
+++ b/src/or/status.c
@@ -14,6 +14,7 @@
#include "router.h"
#include "circuitlist.h"
#include "main.h"
+#include "rephist.h"
#include "hibernate.h"
#include "statefile.h"
@@ -128,6 +129,11 @@ log_heartbeat(time_t now)
log_notice(LD_HEARTBEAT, "TLS write overhead: %.f%%", overhead);
}
+ /* Also commandeer this opportunity to log how our circuit handshake
+ * stats have been doing. */
+ if (public_server_mode(options))
+ rep_hist_log_circuit_handshake_stats(now);
+
tor_free(uptime);
tor_free(bw_sent);
tor_free(bw_rcvd);