aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMike Perry <mikeperry-git@fscked.org>2012-11-25 17:29:16 -0800
committerMike Perry <mikeperry-git@fscked.org>2012-12-07 15:28:38 -0800
commitdc86d7c35bd48d12d84feb6f63014904eabe0902 (patch)
treecf4a2d7ad4e980ed873bb8c8daee4d471236fe01 /src
parentecaeb505fab12985d314aace49f1277b1b58dc1b (diff)
downloadtor-dc86d7c35bd48d12d84feb6f63014904eabe0902.tar
tor-dc86d7c35bd48d12d84feb6f63014904eabe0902.tar.gz
Note more potential issues.
Diffstat (limited to 'src')
-rw-r--r--src/or/circuitlist.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/or/circuitlist.c b/src/or/circuitlist.c
index eb7fc7528..7163c351c 100644
--- a/src/or/circuitlist.c
+++ b/src/or/circuitlist.c
@@ -1383,6 +1383,12 @@ circuit_mark_for_close_(circuit_t *circ, int reason, int line,
pathbias_count_collapse(ocirc);
}
} else if (circ->timestamp_dirty && !ocirc->any_streams_succeeded) {
+ // XXX: May open up attacks if the adversary can force connections
+ // on unresponsive hosts to use new circs. Vidalia displayes a "Retrying"
+ // state.. Can we use that? Does optimistic data change this?
+ // XXX: For the hidserv side, we could only care about INTRODUCING purposes
+ // for server+client, and REND purposes for the server... Can we
+ // somehow only count those?
/* Any circuit where there were attempted streams but no successful
* streams could be bias */
/* FIXME: This may be better handled by limiting the number of retries