diff options
| author | Mike Perry <mikeperry-git@fscked.org> | 2013-02-04 16:59:28 -0800 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2013-02-07 14:30:58 -0500 |
| commit | b03553737cdfa460d33a425a53908c83fe871ec4 (patch) | |
| tree | 17a17b13f2f6c4cbd8e1c72d238d0ee0396179d9 /src | |
| parent | 2b68a06618433b8c9ddf68d2d0e78625ad8cc204 (diff) | |
| download | tor-b03553737cdfa460d33a425a53908c83fe871ec4.tar tor-b03553737cdfa460d33a425a53908c83fe871ec4.tar.gz | |
Separate the flags for logging use bias.
I think we want both sets of messages to appear independently to help us know
what needs tuning.
Diffstat (limited to 'src')
| -rw-r--r-- | src/or/circuitbuild.c | 8 | ||||
| -rw-r--r-- | src/or/entrynodes.h | 4 |
2 files changed, 8 insertions, 4 deletions
diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index e94daca02..26edccd79 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -2273,8 +2273,8 @@ pathbias_measure_use_rate(entry_guard_t *guard) entry_guards_changed(); return; } - } else if (!guard->path_bias_extreme) { - guard->path_bias_extreme = 1; + } else if (!guard->path_bias_use_extreme) { + guard->path_bias_use_extreme = 1; log_warn(LD_CIRC, "Your Guard %s=%s is failing to carry an extremely large " "amount of streams on its circuits. " @@ -2297,8 +2297,8 @@ pathbias_measure_use_rate(entry_guard_t *guard) } } else if (pathbias_get_use_success_count(guard)/guard->use_attempts < pathbias_get_notice_use_rate(options)) { - if (!guard->path_bias_noticed) { - guard->path_bias_noticed = 1; + if (!guard->path_bias_use_noticed) { + guard->path_bias_use_noticed = 1; log_notice(LD_CIRC, "Your Guard %s=%s is failing to carry more streams on its " "circuits than usual. " diff --git a/src/or/entrynodes.h b/src/or/entrynodes.h index e6c973c95..b673d0268 100644 --- a/src/or/entrynodes.h +++ b/src/or/entrynodes.h @@ -39,6 +39,10 @@ typedef struct entry_guard_t { * bias for this node already? */ unsigned int path_bias_disabled : 1; /**< Have we disabled this node because * of path bias issues? */ + unsigned int path_bias_use_noticed : 1; /**< Did we alert the user about path + * use bias for this node already? */ + unsigned int path_bias_use_extreme : 1; /**< Did we alert the user about path + * use bias for this node already? */ unsigned int is_dir_cache : 1; /**< Is this node a directory cache? */ time_t bad_since; /**< 0 if this guard is currently usable, or the time at * which it was observed to become (according to the |