aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2011-10-28 18:05:25 -0400
committerNick Mathewson <nickm@torproject.org>2011-10-28 18:05:25 -0400
commit4dd8d811d669e245f95ed0fcc59de579e876ab91 (patch)
tree312d1d26b28462b568269f2506fa26008524b610 /src
parent00a0de8508f4cb5ab28b91884c3ca1733e2a174f (diff)
parent2018f86e0c7f088de54ff8f7f4d1e04075785206 (diff)
downloadtor-4dd8d811d669e245f95ed0fcc59de579e876ab91.tar
tor-4dd8d811d669e245f95ed0fcc59de579e876ab91.tar.gz
Merge branch 'bug4343'
Diffstat (limited to 'src')
-rw-r--r--src/common/tortls.c2
-rw-r--r--src/or/command.c6
2 files changed, 4 insertions, 4 deletions
diff --git a/src/common/tortls.c b/src/common/tortls.c
index 7aaa4e089..8cf396cda 100644
--- a/src/common/tortls.c
+++ b/src/common/tortls.c
@@ -694,7 +694,7 @@ tor_cert_free(tor_cert_t *cert)
if (cert->cert)
X509_free(cert->cert);
tor_free(cert->encoded);
- memset(cert, 0x03, sizeof(cert));
+ memset(cert, 0x03, sizeof(*cert));
tor_free(cert);
}
diff --git a/src/or/command.c b/src/or/command.c
index 43d304e07..c02d353bb 100644
--- a/src/or/command.c
+++ b/src/or/command.c
@@ -1026,8 +1026,6 @@ command_process_cert_cell(var_cell_t *cell, or_connection_t *conn)
ERR("The certs we wanted were missing");
/* Remember these certificates so we can check an AUTHENTICATE cell */
- conn->handshake_state->id_cert = id_cert;
- conn->handshake_state->auth_cert = auth_cert;
if (! tor_tls_cert_is_valid(auth_cert, id_cert, 1))
ERR("The authentication certificate was not valid");
if (! tor_tls_cert_is_valid(id_cert, id_cert, 1))
@@ -1038,6 +1036,8 @@ command_process_cert_cell(var_cell_t *cell, or_connection_t *conn)
safe_str(conn->_base.address), conn->_base.port);
/* XXXX check more stuff? */
+ conn->handshake_state->id_cert = id_cert;
+ conn->handshake_state->auth_cert = auth_cert;
id_cert = auth_cert = NULL;
}
@@ -1141,7 +1141,7 @@ command_process_authenticate_cell(var_cell_t *cell, or_connection_t *conn)
#define ERR(s) \
do { \
log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL, \
- "Received a bad AUTHETNICATE cell from %s:%d: %s", \
+ "Received a bad AUTHENTICATE cell from %s:%d: %s", \
safe_str(conn->_base.address), conn->_base.port, (s)); \
connection_mark_for_close(TO_CONN(conn)); \
return; \