diff options
author | Roger Dingledine <arma@torproject.org> | 2003-06-24 05:17:39 +0000 |
---|---|---|
committer | Roger Dingledine <arma@torproject.org> | 2003-06-24 05:17:39 +0000 |
commit | a43c015838b183a3ad535d06f09145fa34e0f6c1 (patch) | |
tree | de6110aaae0b9a1dc88735cb171e46092efcff34 /src/or | |
parent | e061b70dbf1a55244a66f1e6d7a0085fbebb5857 (diff) | |
download | tor-a43c015838b183a3ad535d06f09145fa34e0f6c1.tar tor-a43c015838b183a3ad535d06f09145fa34e0f6c1.tar.gz |
clean out some old comments
svn:r348
Diffstat (limited to 'src/or')
-rw-r--r-- | src/or/connection.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/src/or/connection.c b/src/or/connection.c index db3751446..7877e958e 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -434,20 +434,10 @@ void connection_send_cell(connection_t *conn) { connection_write_cell_to_buf(&cell, conn); } - /* ???? If we might not have added a cell above, why are we - * ???? increasing outbuf_flushlen? -NM */ /* The connection_write_cell_to_buf() call doesn't increase the flushlen * (if link padding is on). So if there isn't a whole cell waiting-but- * not-yet-flushed, we add a padding cell. Thus in any case the gap between - * outbuf_datalen and outbuf_flushlen is at least sizeof(cell_t). -RD - */ - /* XXXX actually, there are some subtle bugs lurking in here. They - * have to do with the fact that we don't handle connection failure - * cleanly. Sometimes we mark things to be closed later. Inside - * connection_write_cell_to_buf, it returns successfully without - * writing if the connection has been marked for close. We need to - * look at all our failure cases more carefully and make sure they do - * the right thing. + * outbuf_datalen and outbuf_flushlen is at least sizeof(cell_t). */ conn->outbuf_flushlen += sizeof(cell_t); /* instruct it to send a cell */ connection_start_writing(conn); |