diff options
| author | dana koch <dsk@google.com> | 2014-04-15 22:20:34 +1000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2014-04-15 15:00:34 -0400 |
| commit | 3ce3984772b673b82a87aded1bc8a1a0f1969e19 (patch) | |
| tree | ae9e005f34ae81ff04c006ef179575de5b277bb8 /src/or/nodelist.c | |
| parent | 2704441e7ff1242d168bc14dda946fc41844f2c5 (diff) | |
| download | tor-3ce3984772b673b82a87aded1bc8a1a0f1969e19.tar tor-3ce3984772b673b82a87aded1bc8a1a0f1969e19.tar.gz | |
Uplift status.c unit test coverage with new test cases and macros.
A new set of unit test cases are provided, as well as introducing
an alternative paradigm and macros to support it. Primarily, each test
case is given its own namespace, in order to isolate tests from each
other. We do this by in the usual fashion, by appending module and
submodule names to our symbols. New macros assist by reducing friction
for this and other tasks, like overriding a function in the global
namespace with one in the current namespace, or declaring integer
variables to assist tracking how many times a mock has been called.
A set of tests for a small-scale module has been included in this
commit, in order to highlight how the paradigm can be used. This
suite gives 100% coverage to status.c in test execution.
Diffstat (limited to 'src/or/nodelist.c')
| -rw-r--r-- | src/or/nodelist.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/or/nodelist.c b/src/or/nodelist.c index 52c92661c..a38a6d499 100644 --- a/src/or/nodelist.c +++ b/src/or/nodelist.c @@ -85,8 +85,8 @@ node_get_mutable_by_id(const char *identity_digest) /** Return the node_t whose identity is <b>identity_digest</b>, or NULL * if no such node exists. */ -const node_t * -node_get_by_id(const char *identity_digest) +MOCK_IMPL(const node_t *, +node_get_by_id,(const char *identity_digest)) { return node_get_mutable_by_id(identity_digest); } |